Bug 183463 – [webkitpy] Bugzilla class should use NetworkTransaction for network POST requests

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Tools / Tests

[Aakash Jain]

https://bugs.webkit.org/show_bug.cgi?id=182420 added retry for network GET requests (by using NetworkTransaction). We should try to add retry to POST requests as well. Note that this might require additional testing as retrying on POST has a possibility of messing up things. 

However, it's possible that Bugzilla handle the duplicate POST requests properly. Also, the network issues we are noticing might be at the client side, and in these cases, the request might not even be reaching the server (bugzilla), so retrying might be safe.

[Aakash Jain]

Typo: https://bugs.webkit.org/show_bug.cgi?id=183222 added retry on network GET requests.

[Aakash Jain]

Happened in https://bugs.webkit.org/show_bug.cgi?id=183455 (https://webkit-queues.webkit.org/results/6858890)

Failed in:
File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 778, in clear_attachment_flags
    self.browser.submit()

[Aakash Jain]

Another error:
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 826, in add_cc_to_bug
    self.browser.submit()

Complete exception:
2018-03-08 13:45:36,000 - Fetching: https://bugs.webkit.org/attachment.cgi?id=335323&action=edit
2018-03-08 13:45:36,271 - Fetching: https://bugs.webkit.org/show_bug.cgi?id=183467&ctype=xml&excludefield=attachmentdata
2018-03-08 13:45:36,509 - Adding [] to the CC list for bug 183467
Traceback (most recent call last):
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/queues.py", line 81, in _cc_watchers
    self._tool.bugs.add_cc_to_bug(bug_id, self.watchers)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 826, in add_cc_to_bug
    self.browser.submit()
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 541, in submit
    return self.open(self.click(*args, **kwds))
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open
    return self._mech_open(url, data, timeout=timeout)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 230, in _mech_open
    response = UserAgentBase.open(self, request, data)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_opener.py", line 193, in open
    response = urlopen(self, req, data)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 344, in _open
    '_open', req)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain
    result = func(*args)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open
    return self.do_open(conn_factory, req)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open
    raise URLError(err)
URLError: <urlopen error [Errno 60] Operation timed out>
2018-03-08 13:46:51,928 - Failed to CC watchers.

[Aakash Jain]

EWS stopped using this webkitpy code (and use Bugzilla REST API directly). So, this isn't a problem/priority anymore.