Bug 183460 – http/tests/security/frame-loading-via-document-write-async-delegates.html fails with async delegates

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Chris Dumez]

http/tests/security/frame-loading-via-document-write-async-delegates.html fails with async delegates.

[Chris Dumez]

Created attachment 335314 [details]
Patch

[Ali Juma]

*** Bug 183461 has been marked as a duplicate of this bug. ***

[WebKit Commit Bot]

Comment on attachment 335314 [details]
Patch

Clearing flags on attachment: 335314

Committed r229468: <https://trac.webkit.org/changeset/229468>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/38308346>

[Matt Lewis]

This caused the test http/tests/security/frame-loading-via-document-write.html to fail consistently on all platforms:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fsecurity%2Fframe-loading-via-document-write.html

https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r229487%20(3367)/results.html

diff:
--- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/security/frame-loading-via-document-write-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/security/frame-loading-via-document-write-actual.txt
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: line 1: Not allowed to load local resource: abe.png
+CONSOLE MESSAGE: line 55: Not allowed to load local resource: abe.png
 
 
 --------

[Chris Dumez]

(In reply to Matt Lewis from comment #6)
> This caused the test
> http/tests/security/frame-loading-via-document-write.html to fail
> consistently on all platforms:
> 
> https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=http%2Ftests%2Fsecurity%2Fframe-loading-via-
> document-write.html
> 
> https://build.webkit.org/results/
> Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r229487%20(3367)/results.html
> 
> diff:
> ---
> /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/
> http/tests/security/frame-loading-via-document-write-expected.txt
> +++
> /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/
> http/tests/security/frame-loading-via-document-write-actual.txt
> @@ -1,4 +1,4 @@
> -CONSOLE MESSAGE: line 1: Not allowed to load local resource: abe.png
> +CONSOLE MESSAGE: line 55: Not allowed to load local resource: abe.png
>  
>  
>  --------

Looks like this merely needs rebaselining. Weird that EWS was green...

[Ryan Haddad]

Reverted r229468 for reason:

This change caused http/tests/security/frame-loading-via-document-write.html to fail.

Committed r229496: <https://trac.webkit.org/changeset/229496>

[Chris Dumez]

Created attachment 335601 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 335601 [details]
Patch

Rejecting attachment 335601 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 335601, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/6916570

[Chris Dumez]

Created attachment 335603 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 335603 [details]
Patch

Clearing flags on attachment: 335603

Committed r229539: <https://trac.webkit.org/changeset/229539>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.