Bug 183450 - [Win] Use __debugbreak for WTFBreakpointTrap
Summary: [Win] Use __debugbreak for WTFBreakpointTrap
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-08 06:24 PST by Yusuke Suzuki
Modified: 2018-03-08 07:48 PST (History)
11 users (show)

See Also:

Attachments
Patch (1.51 KB, patch)
2018-03-08 06:25 PST, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-03-08 06:24:46 PST 
[Win] Use __debugbreak for WTFBreakpointTrap
Comment 1 Yusuke Suzuki 2018-03-08 06:25:51 PST 
Created attachment 335296 [details]
Patch
Comment 2 Mark Lam 2018-03-08 07:24:54 PST 
Comment on attachment 335296 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335296&action=review

r=me

> Source/WTF/wtf/Assertions.h:212
> +#else
>  #if ASAN_ENABLED

Change this into an "#elif ASAN_ENABLED" because these cases should all be mutually exclusive.

> Source/WTF/wtf/Assertions.h:223
> +#endif // COMPILER(MSVC)

Remove this.
Comment 3 Yusuke Suzuki 2018-03-08 07:43:35 PST 
Comment on attachment 335296 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335296&action=review

Thank you!

>> Source/WTF/wtf/Assertions.h:212
>>  #if ASAN_ENABLED
> 
> Change this into an "#elif ASAN_ENABLED" because these cases should all be mutually exclusive.

OK, changed.

>> Source/WTF/wtf/Assertions.h:223
>> +#endif // COMPILER(MSVC)
> 
> Remove this.

Fixed.
Comment 4 Yusuke Suzuki 2018-03-08 07:47:31 PST 
Committed r229409: <https://trac.webkit.org/changeset/229409>
Comment 5 Radar WebKit Bug Importer 2018-03-08 07:48:34 PST 
<rdar://problem/38262145>