Bug 183449 - [JSC][WebCore] Extend jsDynamicCast for WebCore types in WebCore and remove jsDynamicDowncast
Summary: [JSC][WebCore] Extend jsDynamicCast for WebCore types in WebCore and remove j...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
: 172685 (view as bug list)
Depends on: 183429
Blocks:
  Show dependency treegraph
 
Reported: 2018-03-08 06:12 PST by Yusuke Suzuki
Modified: 2018-04-01 12:26 PDT (History)
2 users (show)

See Also:


Attachments
Patch (209.35 KB, patch)
2018-03-08 09:11 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (209.35 KB, patch)
2018-03-08 09:47 PST, Yusuke Suzuki
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-03-08 06:12:13 PST
Now, jsDynamicCast has the same / similar mechanism to WebCore::jsDynamicDowncast to inject efficient casting.
So, let's remove jsDynamicDowncast. And inject WebCore specializations into JSC::jsDynamicCast in WebCore side.
Comment 1 Yusuke Suzuki 2018-03-08 09:11:03 PST
Created attachment 335301 [details]
Patch
Comment 2 Yusuke Suzuki 2018-03-08 09:47:07 PST
Created attachment 335310 [details]
Patch
Comment 3 Mark Lam 2018-03-08 10:17:02 PST
Comment on attachment 335310 [details]
Patch

r=me
Comment 4 Yusuke Suzuki 2018-03-08 10:38:16 PST
Committed r229416: <https://trac.webkit.org/changeset/229416>
Comment 5 Radar WebKit Bug Importer 2018-03-08 10:39:30 PST
<rdar://problem/38268343>
Comment 6 Yusuke Suzuki 2018-04-01 12:26:12 PDT
*** Bug 172685 has been marked as a duplicate of this bug. ***