Bug 183430 – Stop using SDK conditionals to control feature definitions

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Stop using SDK conditionals to control feature definitions

[Tim Horton]

Created attachment 335267 [details]
Patch

[Tim Horton]

<rdar://problem/38251619>

[EWS Watchlist]

Comment on attachment 335267 [details]
Patch

Attachment 335267 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6851742

New failing tests:
imported/w3c/web-platform-tests/dom/events/Event-timestamp-high-resolution.html

[EWS Watchlist]

Created attachment 335274 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 335267 [details]
Patch

Attachment 335267 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6851941

New failing tests:
imported/w3c/web-platform-tests/dom/events/Event-timestamp-high-resolution.html
gamepad/gamepad-event.html
gamepad/gamepad-api.html
gamepad/gamepad-polling-access.html

[EWS Watchlist]

Created attachment 335275 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 335267 [details]
Patch

Attachment 335267 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6851951

New failing tests:
imported/w3c/web-platform-tests/dom/events/Event-timestamp-high-resolution.html

[EWS Watchlist]

Created attachment 335278 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Tim Horton]

Created attachment 335280 [details]
Patch

Comment on attachment 335280 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335280&action=review

> Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:304
> +ENABLE_VIDEO_PRESENTATION_MODE = $(ENABLE_VIDEO_PRESENTATION_MODE_$(PLATFORM_NAME));
> +ENABLE_VIDEO_PRESENTATION_MODE_iphoneos = ENABLE_VIDEO_PRESENTATION_MODE;
> +ENABLE_VIDEO_PRESENTATION_MODE_iphonesimulator = ENABLE_VIDEO_PRESENTATION_MODE;

This changes something for non-iOS Cocoa Touch platforms, right?

> Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:331
> +ENABLE_WEB_RTC_iphoneos[arch=arm64*] = ENABLE_WEB_RTC;
> +ENABLE_WEB_RTC_iphonesimulator[arch=x86_64] = ENABLE_WEB_RTC;

Not sure these architecture conditionals are still necessary.

[Tim Horton]

Created attachment 335666 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 335666 [details]
Patch

Clearing flags on attachment: 335666

Committed r229567: <https://trac.webkit.org/changeset/229567>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.