Bug 183426 - Disable JIT on Cocoa 32-bit ARM.
Summary: Disable JIT on Cocoa 32-bit ARM.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-07 20:27 PST by Keith Miller
Modified: 2018-03-08 12:09 PST (History)
9 users (show)

See Also:


Attachments
Patch (1.15 KB, patch)
2018-03-07 20:27 PST, Keith Miller
no flags Details | Formatted Diff | Diff
Patch (1.17 KB, patch)
2018-03-08 11:30 PST, Keith Miller
msaboff: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2018-03-07 20:27:31 PST
Disable JIT on Cocoa 32-bit ARM.
Comment 1 Keith Miller 2018-03-07 20:27:43 PST
Created attachment 335254 [details]
Patch
Comment 2 EWS Watchlist 2018-03-07 21:58:26 PST
Comment on attachment 335254 [details]
Patch

Attachment 335254 [details] did not pass jsc-ews (mac):
Output: http://webkit-queues.webkit.org/results/6849732

New failing tests:
stress/ftl-get-by-id-getter-exception-interesting-live-state.js.ftl-eager
Comment 3 Keith Miller 2018-03-08 11:27:17 PST
That test failure makes no sense since the bot is 64-bit...
Comment 4 Keith Miller 2018-03-08 11:30:56 PST
Created attachment 335321 [details]
Patch
Comment 5 Michael Saboff 2018-03-08 11:31:53 PST
Comment on attachment 335321 [details]
Patch

rs=me
Comment 6 Keith Miller 2018-03-08 11:33:50 PST
Do the GTK/WPE ports ever set PLATFORM_COCOA? I'm currently operating on the assumption you don't. Let me know if that's not true and I'll find another solution here.
Comment 7 Keith Miller 2018-03-08 11:35:01 PST
Committed r229422: <https://trac.webkit.org/changeset/229422>
Comment 8 Radar WebKit Bug Importer 2018-03-08 11:35:20 PST
<rdar://problem/38270584>
Comment 9 Michael Catanzaro 2018-03-08 12:09:04 PST
(In reply to Keith Miller from comment #6)
> Do the GTK/WPE ports ever set PLATFORM_COCOA? I'm currently operating on the
> assumption you don't.

You're right!