Bug 183409 - webkitpy: --dedicated-simulators does not boot the correct number of simulators
Summary: webkitpy: --dedicated-simulators does not boot the correct number of simulators
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-07 09:35 PST by Jonathan Bedard
Modified: 2018-03-07 16:07 PST (History)
8 users (show)

See Also:

Attachments
Patch (1.57 KB, patch)
2018-03-07 09:39 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews206 for win-future (12.01 MB, application/zip)
2018-03-07 11:32 PST, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2018-03-07 09:35:36 PST 
When --dedicated-simulators is used, we incorrectly use the number of booted simulators as the number of processes to use.
Comment 1 Radar WebKit Bug Importer 2018-03-07 09:35:58 PST 
<rdar://problem/38224631>
Comment 2 Jonathan Bedard 2018-03-07 09:39:22 PST 
Created attachment 335197 [details]
Patch
Comment 3 EWS Watchlist 2018-03-07 11:32:40 PST 
Comment on attachment 335197 [details]
Patch

Attachment 335197 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/6841440

New failing tests:
http/wpt/resource-timing/rt-initiatorType-media.html
Comment 4 EWS Watchlist 2018-03-07 11:32:50 PST 
Created attachment 335202 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 Jonathan Bedard 2018-03-07 11:39:14 PST 
This patch definitely didn't cause a windows EWS failure.
Comment 6 Aakash Jain 2018-03-07 15:32:41 PST 
Comment on attachment 335197 [details]
Patch

Looks good.
Comment 7 WebKit Commit Bot 2018-03-07 16:07:31 PST 
Comment on attachment 335197 [details]
Patch

Clearing flags on attachment: 335197

Committed r229379: <https://trac.webkit.org/changeset/229379>
Comment 8 WebKit Commit Bot 2018-03-07 16:07:32 PST 
All reviewed patches have been landed.  Closing bug.