Bug 183404 - [GTK][WPE] Leak checker is not working in WebKitGLib web process tests
Summary: [GTK][WPE] Leak checker is not working in WebKitGLib web process tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, InRadar
Depends on:
Blocks:
 
Reported: 2018-03-07 04:20 PST by Carlos Garcia Campos
Modified: 2018-03-07 22:35 PST (History)
7 users (show)

See Also:


Attachments
Patch (26.08 KB, patch)
2018-03-07 04:34 PST, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2018-03-07 04:20:48 PST
This might have regressed when we started to use the JSC garbage collector timers. The thing is that we expect that the WebProcessTester object that we expose to JavaScript is released when the web frame is destroyed, but that's no longer the case. On window object cleared a GC is scheduled, but JSC timers do the actual garbage collection later. In the case of tests that never happens because the web process finishes quickly after the test. We need to force a garbage collection at some point when the web page is destroyed.
Comment 1 Carlos Garcia Campos 2018-03-07 04:34:52 PST
Created attachment 335184 [details]
Patch
Comment 2 Build Bot 2018-03-07 04:36:36 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2018-03-07 22:34:48 PST
Committed r229395: <https://trac.webkit.org/changeset/229395>
Comment 4 Radar WebKit Bug Importer 2018-03-07 22:35:46 PST
<rdar://problem/38250675>