RESOLVED FIXED 183403
[JSC] Add more JSType based fast path for jsDynamicCast 
https://bugs.webkit.org/show_bug.cgi?id=183403
Summary [JSC] Add more JSType based fast path for jsDynamicCast
Yusuke Suzuki
Reported 2018-03-07 04:00:31 PST
[JSC] Add more JSType based fast path for jsDynamicCast
Attachments
Patch (40.87 KB, patch)
2018-03-07 04:16 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (41.06 KB, patch)
2018-03-07 08:00 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-03-07 04:16:56 PST
Created attachment 335183 [details] Patch
Mark Lam
Comment 2 2018-03-07 07:41:15 PST
Comment on attachment 335183 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335183&action=review Nice work. r=me if you resolve EWS failures. > Source/JavaScriptCore/runtime/JSObject.h:1100 > // storage to fully make use of the colloctor cell containing it. Can you fix this typo as well: /colloctor/collector/. > Source/JavaScriptCore/runtime/JSScope.h:43 > + DECLARE_INFO; I suspect that you need to use DECLARE_EXPORT_INFO here (see EWS build failure).
Yusuke Suzuki
Comment 3 2018-03-07 07:59:15 PST
Comment on attachment 335183 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335183&action=review Thanks! >> Source/JavaScriptCore/runtime/JSObject.h:1100 >> // storage to fully make use of the colloctor cell containing it. > > Can you fix this typo as well: /colloctor/collector/. Fixed. Also I fixed /sufficent/sufficient/. >> Source/JavaScriptCore/runtime/JSScope.h:43 >> + DECLARE_INFO; > > I suspect that you need to use DECLARE_EXPORT_INFO here (see EWS build failure). Yeah, I think so. I'll upload "Patch for landing" to check it on EWS :).
Yusuke Suzuki
Comment 4 2018-03-07 08:00:10 PST
Created attachment 335192 [details] Patch
Yusuke Suzuki
Comment 5 2018-03-07 08:01:00 PST
Comment on attachment 335192 [details] Patch Oops, cleared r+.
Yusuke Suzuki
Comment 6 2018-03-07 09:18:15 PST
OK, let's land it :D
Yusuke Suzuki
Comment 7 2018-03-07 09:18:56 PST
Committed r229362: <https://trac.webkit.org/changeset/229362>
Radar WebKit Bug Importer
Comment 8 2018-03-07 09:21:17 PST
<rdar://problem/38224191>
Keith Miller
Comment 9 2018-03-07 13:33:06 PST
Comment on attachment 335192 [details] Patch Nice!
Note You need to log in before you can comment on or make changes to this bug.