Bug 183403 - [JSC] Add more JSType based fast path for jsDynamicCast
Summary: [JSC] Add more JSType based fast path for jsDynamicCast
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-07 04:00 PST by Yusuke Suzuki
Modified: 2018-03-07 13:33 PST (History)
6 users (show)

See Also:

Attachments
Patch (40.87 KB, patch)
2018-03-07 04:16 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (41.06 KB, patch)
2018-03-07 08:00 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-03-07 04:00:31 PST 
[JSC] Add more JSType based fast path for jsDynamicCast
Comment 1 Yusuke Suzuki 2018-03-07 04:16:56 PST 
Created attachment 335183 [details]
Patch
Comment 2 Mark Lam 2018-03-07 07:41:15 PST 
Comment on attachment 335183 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335183&action=review

Nice work.  r=me if you resolve EWS failures.

> Source/JavaScriptCore/runtime/JSObject.h:1100
>  // storage to fully make use of the colloctor cell containing it.

Can you fix this typo as well: /colloctor/collector/.

> Source/JavaScriptCore/runtime/JSScope.h:43
> +    DECLARE_INFO;

I suspect that you need to use DECLARE_EXPORT_INFO here (see EWS build failure).
Comment 3 Yusuke Suzuki 2018-03-07 07:59:15 PST 
Comment on attachment 335183 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335183&action=review

Thanks!

>> Source/JavaScriptCore/runtime/JSObject.h:1100
>>  // storage to fully make use of the colloctor cell containing it.
> 
> Can you fix this typo as well: /colloctor/collector/.

Fixed. Also I fixed /sufficent/sufficient/.

>> Source/JavaScriptCore/runtime/JSScope.h:43
>> +    DECLARE_INFO;
> 
> I suspect that you need to use DECLARE_EXPORT_INFO here (see EWS build failure).

Yeah, I think so. I'll upload "Patch for landing" to check it on EWS :).
Comment 4 Yusuke Suzuki 2018-03-07 08:00:10 PST 
Created attachment 335192 [details]
Patch
Comment 5 Yusuke Suzuki 2018-03-07 08:01:00 PST 
Comment on attachment 335192 [details]
Patch

Oops, cleared r+.
Comment 6 Yusuke Suzuki 2018-03-07 09:18:15 PST 
OK, let's land it :D
Comment 7 Yusuke Suzuki 2018-03-07 09:18:56 PST 
Committed r229362: <https://trac.webkit.org/changeset/229362>
Comment 8 Radar WebKit Bug Importer 2018-03-07 09:21:17 PST 
<rdar://problem/38224191>
Comment 9 Keith Miller 2018-03-07 13:33:06 PST 
Comment on attachment 335192 [details]
Patch

Nice!