Bug 183399 - Simplify the variants of FunctionPtr constructors.
Summary: Simplify the variants of FunctionPtr constructors.
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
Keywords: InRadar
Depends on:
Reported: 2018-03-07 00:44 PST by Mark Lam
Modified: 2018-03-07 10:27 PST (History)
10 users (show)

See Also:

proposed patch. (6.88 KB, patch)
2018-03-07 00:58 PST, Mark Lam
ysuzuki: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2018-03-07 00:44:37 PST
We should able to use a templatized constructor instead of explicitly declaring variants based on function prototypes.
Comment 1 Radar WebKit Bug Importer 2018-03-07 00:45:05 PST
Comment 2 Mark Lam 2018-03-07 00:58:23 PST
Created attachment 335177 [details]
proposed patch.
Comment 3 Yusuke Suzuki 2018-03-07 08:03:03 PST
Comment on attachment 335177 [details]
proposed patch.

Nice, r=me.
Comment 4 Mark Lam 2018-03-07 09:43:12 PST
Comment on attachment 335177 [details]
proposed patch.

Thanks for the review.  Let's land this.
Comment 5 WebKit Commit Bot 2018-03-07 10:21:45 PST
Comment on attachment 335177 [details]
proposed patch.

Rejecting attachment 335177 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 335177, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
st, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Auto packing the repository in background for optimum performance.
See "git help gc" for manual housekeeping.
error: The last gc run reported the following. Please correct the root cause
and remove /Volumes/Data/EWS/WebKit/.git/gc.log.
Automatic cleanup will not be performed until the file is removed.

warning: There are too many unreachable loose objects; run 'git prune' to remove them.

Full output: http://webkit-queues.webkit.org/results/6841108
Comment 6 Mark Lam 2018-03-07 10:27:57 PST
Landed in r229367: <https://trac.webkit.org/r229367>.