Bug 183399 – Simplify the variants of FunctionPtr constructors.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

We should able to use a templatized constructor instead of explicitly declaring variants based on function prototypes.

[Radar WebKit Bug Importer]

<rdar://problem/38212980>

[Mark Lam]

Created attachment 335177 [details]
proposed patch.

[Yusuke Suzuki]

Comment on attachment 335177 [details]
proposed patch.

Nice, r=me.

[Mark Lam]

Comment on attachment 335177 [details]
proposed patch.

Thanks for the review.  Let's land this.

[WebKit Commit Bot]

Comment on attachment 335177 [details]
proposed patch.

Rejecting attachment 335177 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 335177, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
st, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Auto packing the repository in background for optimum performance.
See "git help gc" for manual housekeeping.
error: The last gc run reported the following. Please correct the root cause
and remove /Volumes/Data/EWS/WebKit/.git/gc.log.
Automatic cleanup will not be performed until the file is removed.

warning: There are too many unreachable loose objects; run 'git prune' to remove them.


Full output: http://webkit-queues.webkit.org/results/6841108

[Mark Lam]

Landed in r229367: <https://trac.webkit.org/r229367>.