Bug 183394 – http/tests/dom/window-open-about-webkit-org-and-access-document.html is failing with async policy delegates

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Chris Dumez]

http/tests/dom/window-open-about-webkit-org-and-access-document.html is failing with async policy delegates.

[Chris Dumez]

Created attachment 335169 [details]
Patch

[Alex Christensen]

Comment on attachment 335169 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335169&action=review

> LayoutTests/ChangeLog:10
> +        newWindow.document, expecting it to throw. However, there is no guarantee that the cross origin URL has

What is the behavior of other browsers in this case?

[Chris Dumez]

Comment on attachment 335169 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335169&action=review

>> LayoutTests/ChangeLog:10
>> +        newWindow.document, expecting it to throw. However, there is no guarantee that the cross origin URL has
> 
> What is the behavior of other browsers in this case?

This exact URL is not easily testable in other browsers.

Firefox does not allow loading such URL:
$ window.open("about://webkit.org")
Error: Access to 'about://webkit.org' from script denied

In Chrome:
$ window.open("about://webkit.org").document.URL
about://webkit.org"

but the URL bar of the popup says about:blank. They also do not treat such window as being cross-origin. John tells me Chrome rewrites the URL to about:blank in such cases.

If I try a proper cross-origin URL:

Firefox and Chrome but return:
$ window.open("https://www.webkit.org").document.URL
"about:blank"

So the behavior for cross-origin URLs is consistent and this is why I believe my change is correct. The issue with "about://webkit.org" is that Chrome does not treat it as cross-origin and Firefox does not even allow opening a window with such URL.

[WebKit Commit Bot]

Comment on attachment 335169 [details]
Patch

Rejecting attachment 335169 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 335169, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
st, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Auto packing the repository in background for optimum performance.
See "git help gc" for manual housekeeping.
error: The last gc run reported the following. Please correct the root cause
and remove /Volumes/Data/EWS/WebKit/.git/gc.log.
Automatic cleanup will not be performed until the file is removed.

warning: There are too many unreachable loose objects; run 'git prune' to remove them.


Full output: http://webkit-queues.webkit.org/results/6841309

[WebKit Commit Bot]

Comment on attachment 335169 [details]
Patch

Rejecting attachment 335169 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 335169, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
outTests/http/tests/dom/window-open-about-webkit-org-and-access-document-expected.txt.rej
patching file LayoutTests/http/tests/dom/window-open-about-webkit-org-and-access-document.html
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/http/tests/dom/window-open-about-webkit-org-and-access-document.html.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alex Christensen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/6841433

[WebKit Commit Bot]

Comment on attachment 335169 [details]
Patch

Rejecting attachment 335169 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 335169, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
outTests/http/tests/dom/window-open-about-webkit-org-and-access-document-expected.txt.rej
patching file LayoutTests/http/tests/dom/window-open-about-webkit-org-and-access-document.html
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/http/tests/dom/window-open-about-webkit-org-and-access-document.html.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alex Christensen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/6841558

[Chris Dumez]

Looks like the CQ committed it anyway in 229369.