Bug 183384 - Match unsupported plugins based on domains and not origin
Summary: Match unsupported plugins based on domains and not origin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-06 14:19 PST by youenn fablet
Modified: 2018-03-07 18:07 PST (History)
7 users (show)

See Also:

Attachments
Patch (31.25 KB, patch)
2018-03-06 15:47 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Fixing win (33.50 KB, patch)
2018-03-06 16:54 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (36.76 KB, patch)
2018-03-07 13:26 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-03-06 14:19:33 PST 
Origins are too restrictive.
API should be able to allow a plug-in for a subdomain like example.com or example.co.uk.
Comment 1 youenn fablet 2018-03-06 15:47:35 PST 
Created attachment 335153 [details]
Patch
Comment 2 youenn fablet 2018-03-06 16:54:51 PST 
Created attachment 335157 [details]
Fixing win
Comment 3 Chris Dumez 2018-03-07 13:12:11 PST 
Comment on attachment 335157 [details]
Fixing win

View in context: https://bugs.webkit.org/attachment.cgi?id=335157&action=review

> Source/WebCore/ChangeLog:9
> +        We iterate through the vector and a matc happens if the page host name ends with the provided matching domain.

typo: matc
Comment 4 youenn fablet 2018-03-07 13:26:43 PST 
Created attachment 335211 [details]
Patch
Comment 5 WebKit Commit Bot 2018-03-07 18:06:44 PST 
Comment on attachment 335211 [details]
Patch

Clearing flags on attachment: 335211

Committed r229390: <https://trac.webkit.org/changeset/229390>
Comment 6 WebKit Commit Bot 2018-03-07 18:06:45 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-03-07 18:07:26 PST 
<rdar://problem/38245892>