Bug 183383 - webkitfullscreenchange event not fired at the same time as :-webkit-full-screen pseudo selector changes; causes glitchiness
Summary: webkitfullscreenchange event not fired at the same time as :-webkit-full-scre...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks: 183490
  Show dependency treegraph
 
Reported: 2018-03-06 13:39 PST by Jer Noble
Modified: 2024-08-05 14:03 PDT (History)
13 users (show)

See Also:


Attachments
Patch (7.82 KB, patch)
2018-03-06 13:46 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.99 MB, application/zip)
2018-03-06 15:07 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews100 for mac-sierra (2.49 MB, application/zip)
2018-03-06 15:08 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews112 for mac-sierra (3.42 MB, application/zip)
2018-03-06 15:17 PST, EWS Watchlist
no flags Details
Patch (17.32 KB, patch)
2018-03-08 17:56 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-sierra (2.32 MB, application/zip)
2018-03-08 19:16 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews116 for mac-sierra (2.95 MB, application/zip)
2018-03-08 19:41 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.20 MB, application/zip)
2018-03-08 19:42 PST, EWS Watchlist
no flags Details
Patch (16.01 KB, patch)
2018-03-08 22:20 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews113 for mac-sierra (2.93 MB, application/zip)
2018-03-08 23:59 PST, EWS Watchlist
no flags Details
Patch (16.14 KB, patch)
2018-03-09 00:04 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Follow-up patch (3.05 KB, patch)
2018-03-09 13:46 PST, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-03-06 13:39:57 PST
webkitfullscreenchange event not fired at the same time as :-webkit-full-screen pseudo selector changes; causes glitchiness
Comment 1 Jer Noble 2018-03-06 13:46:13 PST
Created attachment 335137 [details]
Patch
Comment 2 EWS Watchlist 2018-03-06 15:07:45 PST Comment hidden (obsolete)
Comment 3 EWS Watchlist 2018-03-06 15:07:46 PST Comment hidden (obsolete)
Comment 4 Radar WebKit Bug Importer 2018-03-06 15:08:08 PST
<rdar://problem/38197028>
Comment 5 EWS Watchlist 2018-03-06 15:08:38 PST Comment hidden (obsolete)
Comment 6 EWS Watchlist 2018-03-06 15:08:39 PST Comment hidden (obsolete)
Comment 7 EWS Watchlist 2018-03-06 15:17:50 PST Comment hidden (obsolete)
Comment 8 EWS Watchlist 2018-03-06 15:17:52 PST Comment hidden (obsolete)
Comment 9 Jer Noble 2018-03-08 17:56:41 PST
Created attachment 335377 [details]
Patch
Comment 10 EWS Watchlist 2018-03-08 19:16:37 PST
Comment on attachment 335377 [details]
Patch

Attachment 335377 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6868193

New failing tests:
media/media-fullscreen-return-to-inline.html
media/media-fullscreen-pause-inline.html
Comment 11 EWS Watchlist 2018-03-08 19:16:39 PST
Created attachment 335384 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 12 EWS Watchlist 2018-03-08 19:41:12 PST
Comment on attachment 335377 [details]
Patch

Attachment 335377 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6868321

New failing tests:
media/media-fullscreen-return-to-inline.html
media/media-fullscreen-pause-inline.html
media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html
Comment 13 EWS Watchlist 2018-03-08 19:41:13 PST
Created attachment 335385 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 14 EWS Watchlist 2018-03-08 19:42:53 PST
Comment on attachment 335377 [details]
Patch

Attachment 335377 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6868323

New failing tests:
media/media-fullscreen-pause-inline.html
Comment 15 EWS Watchlist 2018-03-08 19:42:54 PST
Created attachment 335386 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 16 Jer Noble 2018-03-08 22:20:43 PST
Created attachment 335393 [details]
Patch
Comment 17 EWS Watchlist 2018-03-08 23:59:40 PST
Comment on attachment 335393 [details]
Patch

Attachment 335393 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6871492

New failing tests:
media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html
Comment 18 EWS Watchlist 2018-03-08 23:59:41 PST
Created attachment 335403 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 19 Jer Noble 2018-03-09 00:04:20 PST
Created attachment 335405 [details]
Patch
Comment 20 Eric Carlson 2018-03-09 09:27:31 PST
Comment on attachment 335405 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335405&action=review

> Source/WebCore/ChangeLog:20
> +        A number of layout tests depend on the behavior that the element will be in fullscreen when the 'playing' event
> +        fires. This was true for DRT (but not WKTR), since its fullscreen implementations were deliberately synchronous, but
> +        won't necessarily be true for all ports. Fix this in a subsequent patch.

You should note webkit.org/b/183490 here.
Comment 21 WebKit Commit Bot 2018-03-09 10:21:17 PST
Comment on attachment 335405 [details]
Patch

Clearing flags on attachment: 335405

Committed r229466: <https://trac.webkit.org/changeset/229466>
Comment 22 WebKit Commit Bot 2018-03-09 10:21:18 PST
All reviewed patches have been landed.  Closing bug.
Comment 23 Ryan Haddad 2018-03-09 11:42:51 PST
This change caused API test Fullscreen.TopContentInset to time out:
https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK1%20%28Tests%29/builds/3882
Comment 24 Jer Noble 2018-03-09 12:04:37 PST
(In reply to Ryan Haddad from comment #23)
> This change caused API test Fullscreen.TopContentInset to time out:
> https://build.webkit.org/builders/
> Apple%20High%20Sierra%20Release%20WK1%20%28Tests%29/builds/3882

I'll look into this.
Comment 25 Jer Noble 2018-03-09 13:46:40 PST
Reopening to attach new patch.
Comment 26 Jer Noble 2018-03-09 13:46:41 PST
Created attachment 335456 [details]
Follow-up patch
Comment 27 WebKit Commit Bot 2018-03-09 15:10:09 PST
Comment on attachment 335456 [details]
Follow-up patch

Clearing flags on attachment: 335456

Committed r229487: <https://trac.webkit.org/changeset/229487>
Comment 28 WebKit Commit Bot 2018-03-09 15:10:11 PST
All reviewed patches have been landed.  Closing bug.
Comment 29 Michael Catanzaro 2018-03-13 13:38:46 PDT
Regression: bug #183611