Bug 183378 - NetworkDataTask should enable logging for automation clients
Summary: NetworkDataTask should enable logging for automation clients
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on: 183306
Blocks:
  Show dependency treegraph
 
Reported: 2018-03-06 12:09 PST by Brent Fulgham
Modified: 2018-03-06 14:49 PST (History)
3 users (show)

See Also:


Attachments
Patch (7.31 KB, patch)
2018-03-06 12:15 PST, Brent Fulgham
bburg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2018-03-06 12:09:38 PST
Bug 183306 did not completely fix the logging issues under WebDriver. The NetworkDataTask code was still not recognizing automation clients as needing logging.

This patch corrects NetworkDataTask to check for automation state, in addition to the session type.
Comment 1 Radar WebKit Bug Importer 2018-03-06 12:13:02 PST
<rdar://problem/38189556>
Comment 2 Brent Fulgham 2018-03-06 12:15:31 PST
Created attachment 335126 [details]
Patch
Comment 3 BJ Burg 2018-03-06 14:42:12 PST
Comment on attachment 335126 [details]
Patch

r=me
Comment 4 Brent Fulgham 2018-03-06 14:49:23 PST
Committed r229343: <https://trac.webkit.org/changeset/229343>