Bug 183374 - LayoutTests/http/tests/misc/window-dot-stop.html fails with async policy delegate
Summary: LayoutTests/http/tests/misc/window-dot-stop.html fails with async policy dele...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 180568
  Show dependency treegraph
 
Reported: 2018-03-06 09:41 PST by Danyao Wang
Modified: 2018-03-06 11:24 PST (History)
2 users (show)

See Also:


Attachments
Patch (3.14 KB, patch)
2018-03-06 10:29 PST, Danyao Wang
no flags Details | Formatted Diff | Diff
Fixed typo. Patch for review (3.15 KB, patch)
2018-03-06 10:33 PST, Danyao Wang
cdumez: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Danyao Wang 2018-03-06 09:41:53 PST
This test now fails because with async decide policy, the iframe navigation is canceled before it gets to willSendRequest stage. window.stop is still working as intended.
Comment 1 Danyao Wang 2018-03-06 10:29:00 PST
Created attachment 335112 [details]
Patch
Comment 2 Danyao Wang 2018-03-06 10:33:15 PST
Created attachment 335113 [details]
Fixed typo. Patch for review
Comment 3 Chris Dumez 2018-03-06 10:43:31 PST
Comment on attachment 335113 [details]
Fixed typo. Patch for review

You would also need to fix the existing test. Otherwise, this does not help us enable async delegates by default. In this case though, since there is no code change, I am not convinced it is worth landing any new test. We can merely rebaseline LayoutTests/http/tests/misc/window-dot-stop.html when we enable async delegates by default.
Comment 4 Danyao Wang 2018-03-06 11:24:32 PST
OK that sounds reasonable. I think the failure message I added to the onload events make the test slightly more clear, but this seems minor and I'm OK just rebaseline later.