Bug 183372 – Get rid of custom bindings for History's replaceState() / pushState()

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Get rid of custom bindings for History IDL interface.

[Chris Dumez]

Created attachment 335133 [details]
Patch

[Chris Dumez]

Created attachment 335134 [details]
Patch

[Chris Dumez]

Any takers?

[youenn fablet]

Comment on attachment 335134 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335134&action=review

> Source/WebCore/page/History.cpp:175
> +    m_cachedState = { };

It is not clear to me that why we need to clear m_cachedState here.  Is it an optimization? Or is stateChanged() not be true?

[Chris Dumez]

(In reply to youenn fablet from comment #4)
> Comment on attachment 335134 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=335134&action=review
> 
> > Source/WebCore/page/History.cpp:175
> > +    m_cachedState = { };
> 
> It is not clear to me that why we need to clear m_cachedState here.  Is it
> an optimization? Or is stateChanged() not be true?

This is to maintain the previous behavior. There are tests expecting this behavior that would start failing otherwise.

[Chris Dumez]

(In reply to Chris Dumez from comment #5)
> (In reply to youenn fablet from comment #4)
> > Comment on attachment 335134 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=335134&action=review
> > 
> > > Source/WebCore/page/History.cpp:175
> > > +    m_cachedState = { };
> > 
> > It is not clear to me that why we need to clear m_cachedState here.  Is it
> > an optimization? Or is stateChanged() not be true?
> 
> This is to maintain the previous behavior. There are tests expecting this
> behavior that would start failing otherwise.

Iirc, the issue is that you can pushState then history.back(). If pushState did not blow up the cache, then history.state might return the same cached value from before the pushState. This is observable and tests expect we re-deserialize in such case even though stateChanged() would return false.

[WebKit Commit Bot]

Comment on attachment 335134 [details]
Patch

Clearing flags on attachment: 335134

Committed r229392: <https://trac.webkit.org/changeset/229392>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/38247484>