In r229309, changes in the LLInt::Data::s_exceptionInstructions allocation process are causing crashes on WPE, making the testing bot quit early. Not yet sure what exactly is the cause for this, but the s_exceptionInstructions symbol appears in both libWPEWebKit.so and libTestRunnerInjectedBundle.so, and it might be that it clashes because of that duplication.
(In reply to Zan Dobersek from comment #0) > In r229309, changes in the LLInt::Data::s_exceptionInstructions allocation > process are causing crashes on WPE, making the testing bot quit early. > > Not yet sure what exactly is the cause for this, but the > s_exceptionInstructions symbol appears in both libWPEWebKit.so and > libTestRunnerInjectedBundle.so, and it might be that it clashes because of > that duplication. OK, let's annotate this with JS_EXPORTDATA.
Created attachment 335089 [details] Mini-revert patch
(In reply to Yusuke Suzuki from comment #1) > OK, let's annotate this with JS_EXPORTDATA. WPE doesn't use export macros. (Same for GTK.)
Created attachment 335093 [details] Patch
(In reply to Zan Dobersek from comment #4) > Created attachment 335093 [details] > Patch This avoids the problem on the WPE port by using a narrowed-down list of libraries that the injected bundle .so should be linked against. As such, it avoids the JavaScriptCore archive being linked into the final .so object, avoiding duplicate symbols. Will also test how the GTK+ port is affected by this change, if at all. But in general, on that port the JSC symbols are all bundled into the libjavascriptcoregtk.so object.
(In reply to Zan Dobersek from comment #5) > Will also test how the GTK+ port is affected by this change, if at all. But > in general, on that port the JSC symbols are all bundled into the > libjavascriptcoregtk.so object. No problem with GTK+ with the patch.
(In reply to Michael Catanzaro from comment #3) > (In reply to Yusuke Suzuki from comment #1) > > OK, let's annotate this with JS_EXPORTDATA. > > WPE doesn't use export macros. (Same for GTK.) Oops, thanks!
Comment on attachment 335093 [details] Patch Clearing flags on attachment: 335093 Committed r229325: <https://trac.webkit.org/changeset/229325>
All reviewed patches have been landed. Closing bug.
<rdar://problem/38182758>