RESOLVED FIXED 183364
[GLib] Implement WebsiteDataStore::defaultServiceWorkerRegistrationDirectory(). 
https://bugs.webkit.org/show_bug.cgi?id=183364
Summary [GLib] Implement WebsiteDataStore::defaultServiceWorkerRegistrationDirectory().
Ms2ger (he/him; ⌚ UTC+1/+2)
Reported 2018-03-06 04:20:38 PST
.
Attachments
Patch (1.49 KB, patch)
2018-03-06 04:26 PST, Ms2ger (he/him; ⌚ UTC+1/+2) 		mcatanzaro: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 1 2018-03-06 04:26:57 PST
Created attachment 335085 [details] Patch
EWS Watchlist
Comment 2 2018-03-06 04:29:07 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
WebKit Commit Bot
Comment 3 2018-03-06 05:30:09 PST
Comment on attachment 335085 [details] Patch Rejecting attachment 335085 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 335085, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: e too many unreachable loose objects; run 'git prune' to remove them. Current branch master is up to date. Auto packing the repository in background for optimum performance. See "git help gc" for manual housekeeping. error: The last gc run reported the following. Please correct the root cause and remove /Volumes/Data/EWS/WebKit/.git/gc.log. Automatic cleanup will not be performed until the file is removed. warning: There are too many unreachable loose objects; run 'git prune' to remove them. Full output: http://webkit-queues.webkit.org/results/6824566
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 4 2018-03-06 06:00:54 PST
https://trac.webkit.org/changeset/229320/webkit
Radar WebKit Bug Importer
Comment 5 2018-03-06 06:01:20 PST
<rdar://problem/38177758>
Note You need to log in before you can comment on or make changes to this bug.