Bug 183354 - Ensure system appearance is default for web content
Summary: Ensure system appearance is default for web content
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-05 17:49 PST by Megan Gardner
Modified: 2018-03-06 12:22 PST (History)
3 users (show)

See Also:

Attachments
Patch (12.94 KB, patch)
2018-03-05 17:52 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (8.45 KB, patch)
2018-03-05 18:03 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (12.94 KB, patch)
2018-03-06 10:13 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (12.95 KB, patch)
2018-03-06 11:12 PST, Megan Gardner 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2018-03-05 17:49:10 PST 
Ensure system appearance is default for web content
Comment 1 Megan Gardner 2018-03-05 17:52:29 PST 
Created attachment 335061 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2018-03-05 17:53:46 PST 
<rdar://problem/38162381>
Comment 3 Megan Gardner 2018-03-05 18:03:51 PST 
Created attachment 335062 [details]
Patch
Comment 4 Tim Horton 2018-03-05 21:49:45 PST 
The new files are missing from your patch.
Comment 5 Megan Gardner 2018-03-06 10:13:08 PST 
Created attachment 335111 [details]
Patch
Comment 6 Tim Horton 2018-03-06 10:19:23 PST 
Comment on attachment 335111 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335111&action=review

Please make sure EWS is green before landing.

> Source/WebCore/platform/mac/LocalDefaultSystemAppearance.h:44
> +    NSAppearance* m_savedSystemAppearance;

Star's on the wrong side.

> Source/WebCore/platform/mac/LocalDefaultSystemAppearance.mm:37
> +    m_savedSystemAppearance = [[NSAppearance currentAppearance] retain];

Why is m_savedSystemAppearance not a retainptr?
Comment 7 Megan Gardner 2018-03-06 11:12:53 PST 
Created attachment 335117 [details]
Patch
Comment 8 Tim Horton 2018-03-06 11:27:02 PST 
Comment on attachment 335117 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335117&action=review

> Source/WebCore/platform/mac/LocalDefaultSystemAppearance.mm:38
> +    NSAppearance* newAppearance = [NSAppearance appearanceNamed:NSAppearanceNameAqua];

Stars on the wrong side :)
Comment 9 Megan Gardner 2018-03-06 12:22:14 PST 
https://trac.webkit.org/r229336