Bug 183338 – Follow-up fixes after r228907.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Per Arne Vollan]

There are review comments on the patch in https://bugs.webkit.org/show_bug.cgi?id=182855 which have not been addressed yet. This bug will track this.

[Radar WebKit Bug Importer]

<rdar://problem/38144878>

[Tim Horton]

We really ought to fix the extra message at process initialization part, it’s very strange (I just ran into it looking at another bug).

[Per Arne Vollan]

(In reply to Tim Horton from comment #2)
> We really ought to fix the extra message at process initialization part,
> it’s very strange (I just ran into it looking at another bug).

I am aiming to look into this bug today.

[Per Arne Vollan]

Created attachment 341350 [details]
Patch

[Brent Fulgham]

Comment on attachment 341350 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341350&action=review

I think this change to the launch code might fix a bug David and I have been trying to track down! r=me, but please make sure EWS is happy before landing.

> Source/WebKit/Shared/WebProcessCreationParameters.h:199
> +    HashMap<WebCore::PlatformDisplayID, WebCore::ScreenProperties> screenPropertiesMap;

We use HashMap<WebCore::PlatformDisplayID, WebCore::ScreenProperties> a lot in PlatformScreen. I wonder if we should define a type for this to keep things tidy?

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #5)
> Comment on attachment 341350 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=341350&action=review
> 
> I think this change to the launch code might fix a bug David and I have been
> trying to track down! r=me, but please make sure EWS is happy before landing.
> 
> > Source/WebKit/Shared/WebProcessCreationParameters.h:199
> > +    HashMap<WebCore::PlatformDisplayID, WebCore::ScreenProperties> screenPropertiesMap;
> 
> We use HashMap<WebCore::PlatformDisplayID, WebCore::ScreenProperties> a lot
> in PlatformScreen. I wonder if we should define a type for this to keep
> things tidy?

That's a good idea, I can look into that in a new patch :)

Thanks for reviewing!

[WebKit Commit Bot]

Comment on attachment 341350 [details]
Patch

Clearing flags on attachment: 341350

Committed r232260: <https://trac.webkit.org/changeset/232260>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.