Bug 183338 - Follow-up fixes after r228907.
Summary: Follow-up fixes after r228907.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on: 182855
Blocks:
  Show dependency treegraph
 
Reported: 2018-03-05 10:35 PST by Per Arne Vollan
Modified: 2018-05-29 09:50 PDT (History)
5 users (show)

See Also:


Attachments
Patch (5.23 KB, patch)
2018-05-25 16:24 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2018-03-05 10:35:16 PST
There are review comments on the patch in https://bugs.webkit.org/show_bug.cgi?id=182855 which have not been addressed yet. This bug will track this.
Comment 1 Radar WebKit Bug Importer 2018-03-05 10:35:37 PST
<rdar://problem/38144878>
Comment 2 Tim Horton 2018-05-24 23:46:06 PDT
We really ought to fix the extra message at process initialization part, it’s very strange (I just ran into it looking at another bug).
Comment 3 Per Arne Vollan 2018-05-25 07:42:17 PDT
(In reply to Tim Horton from comment #2)
> We really ought to fix the extra message at process initialization part,
> it’s very strange (I just ran into it looking at another bug).

I am aiming to look into this bug today.
Comment 4 Per Arne Vollan 2018-05-25 16:24:40 PDT
Created attachment 341350 [details]
Patch
Comment 5 Brent Fulgham 2018-05-25 17:05:50 PDT
Comment on attachment 341350 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341350&action=review

I think this change to the launch code might fix a bug David and I have been trying to track down! r=me, but please make sure EWS is happy before landing.

> Source/WebKit/Shared/WebProcessCreationParameters.h:199
> +    HashMap<WebCore::PlatformDisplayID, WebCore::ScreenProperties> screenPropertiesMap;

We use HashMap<WebCore::PlatformDisplayID, WebCore::ScreenProperties> a lot in PlatformScreen. I wonder if we should define a type for this to keep things tidy?
Comment 6 Per Arne Vollan 2018-05-29 09:23:13 PDT
(In reply to Brent Fulgham from comment #5)
> Comment on attachment 341350 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=341350&action=review
> 
> I think this change to the launch code might fix a bug David and I have been
> trying to track down! r=me, but please make sure EWS is happy before landing.
> 
> > Source/WebKit/Shared/WebProcessCreationParameters.h:199
> > +    HashMap<WebCore::PlatformDisplayID, WebCore::ScreenProperties> screenPropertiesMap;
> 
> We use HashMap<WebCore::PlatformDisplayID, WebCore::ScreenProperties> a lot
> in PlatformScreen. I wonder if we should define a type for this to keep
> things tidy?

That's a good idea, I can look into that in a new patch :)

Thanks for reviewing!
Comment 7 WebKit Commit Bot 2018-05-29 09:50:18 PDT
Comment on attachment 341350 [details]
Patch

Clearing flags on attachment: 341350

Committed r232260: <https://trac.webkit.org/changeset/232260>
Comment 8 WebKit Commit Bot 2018-05-29 09:50:19 PDT
All reviewed patches have been landed.  Closing bug.