Bug 183316 – Web Inspector: Sources: add SourcesTabContentView and SourcesSidebarPanel classes

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

"Enable Sources tab" experimental setting should add a new Sources tab. At first,
it will be an exact copy of Resources tab with "resources" renamed to "sources"
where it makes sense.

[Radar WebKit Bug Importer]

<rdar://problem/38107639>

[Nikita Vasilyev]

Created attachment 334969 [details]
Patch

[Matt Baker]

Comment on attachment 334969 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334969&action=review

> Source/WebInspectorUI/UserInterface/Main.html:745
> +    <script src="Views/SourceSidebarPanel.js"></script>

We should be consistent, and pick Source or Sources for these new classes. I'm in favor of SourcesSidebarPanel/SourcesTabContentView, because it stands out from SourceCode* SourceMap* prefixed classes.

> Source/WebInspectorUI/UserInterface/Views/SourceSidebarPanel.js:30
> +        super("source", WI.UIString("Sources"), true);

"sources"

> Source/WebInspectorUI/UserInterface/Views/SourceSidebarPanel.js:37
> +        var scopeItemPrefix = "source-sidebar-";

"sources-sidebar-"

> Source/WebInspectorUI/UserInterface/Views/SourceSidebarPanel.js:38
> +        var scopeBarItems = [];

I realize this file was copy-pasted from ResourceNavigationSidebarPanel, but we might as well find-replace var/let.

> Source/WebInspectorUI/UserInterface/Views/SourceSidebarPanel.js:49
> +        this._scopeBar = new WI.ScopeBar("source-sidebar-scope-bar", scopeBarItems, scopeBarItems[0], true);

"sources-sidebar-scope-bar"

[Nikita Vasilyev]

Created attachment 335356 [details]
Patch

[Matt Baker]

Comment on attachment 335356 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335356&action=review

r=me

> Source/WebInspectorUI/ChangeLog:57
> +        added and the identifier changed from "resources" to "sources".

I think both this, and the previous comment, can be merged into the top-level change log comment:

Add Sources tab and sidebar panel, which are copies of the corresponding Resources classes.
The Sources tab is shown when it's enabled in the experimental settings. This patch doesn't
remove existing Resources and Debugger tabs.

[Nikita Vasilyev]

Created attachment 335366 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 335366 [details]
Patch

Clearing flags on attachment: 335366

Committed r229443: <https://trac.webkit.org/changeset/229443>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.