Bug 183312 – [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

[WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively

[Yusuke Suzuki]

Created attachment 334954 [details]
Patch

[Yusuke Suzuki]

Created attachment 334956 [details]
Patch

[Yusuke Suzuki]

Created attachment 334960 [details]
Patch

[Yusuke Suzuki]

Created attachment 334976 [details]
Patch

[Mark Lam]

Comment on attachment 334976 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334976&action=review

r=me

> Source/WTF/ChangeLog:16
> +        conslidate various time-source implementations in one place.

*consolidate*

[Yusuke Suzuki]

Comment on attachment 334976 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334976&action=review

>> Source/WTF/ChangeLog:16
>> +        conslidate various time-source implementations in one place.
> 
> *consolidate*

Thanks, fixed.

[Yusuke Suzuki]

Created attachment 334985 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 334985 [details]
Patch

Let's go.

[WebKit Commit Bot]

Comment on attachment 334985 [details]
Patch

Clearing flags on attachment: 334985

Committed r229209: <https://trac.webkit.org/changeset/229209>

[JF Bastien]

Comment on attachment 334985 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334985&action=review

> Source/WTF/wtf/cocoa/CPUTimeCocoa.mm:79
> +    thread_info(threadPort, THREAD_BASIC_INFO, reinterpret_cast<thread_info_t>(&info), &infoCount);

RELEASE_ASSERT that it returns KERN_SUCCESS.

> Source/WTF/wtf/unix/CPUTimeUnix.cpp:50
> +    clock_gettime(CLOCK_THREAD_CPUTIME_ID, &ts);

Release assert that it returns 0.

> Source/WTF/wtf/win/CPUTimeWin.cpp:68
> +    ASSERT_UNUSED(ret, ret);

Release assert that it's non-zero.

[Yusuke Suzuki]

Comment on attachment 334985 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334985&action=review

Thank you!

>> Source/WTF/wtf/cocoa/CPUTimeCocoa.mm:79
>> +    thread_info(threadPort, THREAD_BASIC_INFO, reinterpret_cast<thread_info_t>(&info), &infoCount);
> 
> RELEASE_ASSERT that it returns KERN_SUCCESS.

Nice, I'll fix in a follow-up patch.

>> Source/WTF/wtf/unix/CPUTimeUnix.cpp:50
>> +    clock_gettime(CLOCK_THREAD_CPUTIME_ID, &ts);
> 
> Release assert that it returns 0.

Nice, fixed.

>> Source/WTF/wtf/win/CPUTimeWin.cpp:68
>> +    ASSERT_UNUSED(ret, ret);
> 
> Release assert that it's non-zero.

Fixed.

[Yusuke Suzuki]

Committed r229289: <https://trac.webkit.org/changeset/229289>

[Radar WebKit Bug Importer]

<rdar://problem/38146407>

[Yusuke Suzuki]

Committed r229571: <https://trac.webkit.org/changeset/229571>