WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
183301
Build fix after
r229174
https://bugs.webkit.org/show_bug.cgi?id=183301
Summary
Build fix after r229174
Christopher Reid
Reported
2018-03-02 13:31:48 PST
The build fails when #if !PLATFORM(COCOA) && !OS(LINUX) && !OS(WINDOWS) is true MemoryPressureHandler::holdOff was updated to use WTF::Seconds but the MemoryPressureHandler::holdOff definition in that condition is still using unsigned.
Attachments
Patch
(1.40 KB, patch)
2018-03-02 13:34 PST
,
Christopher Reid
achristensen
: review+
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Christopher Reid
Comment 1
2018-03-02 13:34:47 PST
Created
attachment 334921
[details]
Patch
WebKit Commit Bot
Comment 2
2018-03-02 14:00:29 PST
Comment on
attachment 334921
[details]
Patch Rejecting
attachment 334921
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 334921, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: rdparty/autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 60] Operation timed out> Full output:
http://webkit-queues.webkit.org/results/6740411
Christopher Reid
Comment 3
2018-03-02 14:21:06 PST
(In reply to WebKit Commit Bot from
comment #2
)
> Comment on
attachment 334921
[details]
> Patch > > Rejecting
attachment 334921
[details]
from commit-queue.
It looks like the commit-queue landed this patch then marked it as rejected due to a timeout 15 seconds later. The patch landed under
https://trac.webkit.org/changeset/229187/webkit
Christopher Reid
Comment 4
2018-03-02 14:31:15 PST
Manually closing this bug. All patches have landed.
Radar WebKit Bug Importer
Comment 5
2018-03-02 14:33:06 PST
<
rdar://problem/38082498
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug