Bug 183254 – Converting a load to a download does not work with async policy delegates

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Chris Dumez]

Converting a load to a download does not work with async policy delegates.

This causes fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download.html and a few other tests to fail when enabling asyncpolicy delegates.

[Radar WebKit Bug Importer]

<rdar://problem/38035334>

[Chris Dumez]

Created attachment 334839 [details]
WIP Patch

[Chris Dumez]

Created attachment 334842 [details]
Patch

[EWS Watchlist]

Comment on attachment 334842 [details]
Patch

Attachment 334842 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6724935

New failing tests:
fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download-async-delegate.html

[EWS Watchlist]

Created attachment 334849 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Chris Dumez]

Created attachment 334850 [details]
Patch

[youenn fablet]

Comment on attachment 334850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334850&action=review

> Source/WebCore/loader/DocumentLoader.cpp:789
> +    frameLoader()->checkContentPolicy(m_response, [this, protectedThis = makeRef(*this), mainResourceLoader = WTFMove(mainResourceLoader)](PolicyAction policy) {

I guess capturing mainResourceLoader in the lambda is to be extra safe that we call didReceiveResponsePolicy on the exact same loader from which we called markInAsyncResponsePolicyCheck.
Or is there some more subtlety there?

[Chris Dumez]

Comment on attachment 334850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334850&action=review

>> Source/WebCore/loader/DocumentLoader.cpp:789
>> +    frameLoader()->checkContentPolicy(m_response, [this, protectedThis = makeRef(*this), mainResourceLoader = WTFMove(mainResourceLoader)](PolicyAction policy) {
> 
> I guess capturing mainResourceLoader in the lambda is to be extra safe that we call didReceiveResponsePolicy on the exact same loader from which we called markInAsyncResponsePolicyCheck.
> Or is there some more subtlety there?

No subtlety, I thought it looked better :)

[WebKit Commit Bot]

Comment on attachment 334850 [details]
Patch

Clearing flags on attachment: 334850

Committed r229177: <https://trac.webkit.org/changeset/229177>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.