Bug 183246 – REGRESSION(r222843): [HarfBuzz] Combining enclosed keycap not correctly handled

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Carlos Garcia Campos]

While working on bug #183155 I realized that the first emojis shown in http://www.fileformat.info/info/emoji/browsertest.htm were not working. This is because we are not correctly handling the combining enclosed keycap since we switched to use ComplexTextController.

[Carlos Garcia Campos]

Created attachment 334817 [details]
Patch

[Carlos Garcia Campos]

Created attachment 334818 [details]
Patch

[Michael Catanzaro]

Comment on attachment 334818 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334818&action=review

> LayoutTests/platform/gtk/fast/text/combining-enclosing-keycap-expected.txt:1
> +Vector smash protection is enabled.

This shouldn't be in the expected results. Why is this in the expected results? WTF?

[Carlos Garcia Campos]

(In reply to Michael Catanzaro from comment #3)
> Comment on attachment 334818 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=334818&action=review
> 
> > LayoutTests/platform/gtk/fast/text/combining-enclosing-keycap-expected.txt:1
> > +Vector smash protection is enabled.
> 
> This shouldn't be in the expected results. Why is this in the expected
> results? WTF?

Oh! This is because of resource load stats always enabled in tests. It queries the plugins data and stupid flash plugin spits that to stdout when loaded, making all my non-ref tests to fail, btw.

[Carlos Garcia Campos]

Committed r229165: <https://trac.webkit.org/changeset/229165>

[Radar WebKit Bug Importer]

<rdar://problem/38056723>