Bug 183246 - REGRESSION(r222843): [HarfBuzz] Combining enclosed keycap not correctly handled
Summary: REGRESSION(r222843): [HarfBuzz] Combining enclosed keycap not correctly handled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2018-03-01 08:12 PST by Carlos Garcia Campos
Modified: 2018-03-01 22:44 PST (History)
5 users (show)

See Also:


Attachments
Patch (11.15 KB, patch)
2018-03-01 08:32 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Patch (11.20 KB, patch)
2018-03-01 08:36 PST, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2018-03-01 08:12:45 PST
While working on bug #183155 I realized that the first emojis shown in http://www.fileformat.info/info/emoji/browsertest.htm were not working. This is because we are not correctly handling the combining enclosed keycap since we switched to use ComplexTextController.
Comment 1 Carlos Garcia Campos 2018-03-01 08:32:21 PST
Created attachment 334817 [details]
Patch
Comment 2 Carlos Garcia Campos 2018-03-01 08:36:27 PST
Created attachment 334818 [details]
Patch
Comment 3 Michael Catanzaro 2018-03-01 12:15:57 PST
Comment on attachment 334818 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334818&action=review

> LayoutTests/platform/gtk/fast/text/combining-enclosing-keycap-expected.txt:1
> +Vector smash protection is enabled.

This shouldn't be in the expected results. Why is this in the expected results? WTF?
Comment 4 Carlos Garcia Campos 2018-03-01 22:33:06 PST
(In reply to Michael Catanzaro from comment #3)
> Comment on attachment 334818 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=334818&action=review
> 
> > LayoutTests/platform/gtk/fast/text/combining-enclosing-keycap-expected.txt:1
> > +Vector smash protection is enabled.
> 
> This shouldn't be in the expected results. Why is this in the expected
> results? WTF?

Oh! This is because of resource load stats always enabled in tests. It queries the plugins data and stupid flash plugin spits that to stdout when loaded, making all my non-ref tests to fail, btw.
Comment 5 Carlos Garcia Campos 2018-03-01 22:43:27 PST
Committed r229165: <https://trac.webkit.org/changeset/229165>
Comment 6 Radar WebKit Bug Importer 2018-03-01 22:44:28 PST
<rdar://problem/38056723>