Bug 183238 - [Curl] Linker errors in some curl files due to missing exports
Summary: [Curl] Linker errors in some curl files due to missing exports
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-28 18:44 PST by Christopher Reid
Modified: 2018-03-01 09:00 PST (History)
9 users (show)

See Also:

Attachments
Patch (2.36 KB, patch)
2018-02-28 19:00 PST, Christopher Reid 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Reid 2018-02-28 18:44:49 PST 
19>Link : error : L0039: reference to undefined symbol `WebCore::CurlProxySettings::operator= (WebCore::CurlProxySettings const&)' in file "WebKitBuild\Source\WebKit\WebKit.dir\Debug\WebProcessPool.o"
19>Link : error : L0039: reference to undefined symbol `WebCore::CurlContext::singleton()' in file "WebKitBuild\Source\WebKit\WebKit.dir\Debug\NetworkDataTaskCurl.o"
19>Link : error : L0039: reference to undefined symbol `WebCore::CurlProxySettings::setUserPass(WTF::String const&, WTF::String const&)' in file "WebKitBuild\Source\WebKit\WebKit.dir\Debug\NetworkDataTaskCurl.o"
19>Link : error : L0039: reference to undefined symbol `WebCore::CurlProxySettings::isolatedCopy() const' in file "WebKitBuild\Source\WebKit\WebKit.dir\Debug\NetworkProcessCurl.o"
19>Link : error : L0039: reference to undefined symbol `WebCore::CurlProxySettings::CurlProxySettings(WebCore::CurlProxySettings::Mode)' in file "WebKitBuild\Source\WebKit\WebKit.dir\Debug\WebCoreArgumentCodersCurl.o"
19>Link : error : L0039: reference to undefined symbol `WebCore::CurlProxySettings::CurlProxySettings(WebCore::URL const&, WTF::String)' in file "WebKitBuild\Source\WebKit\WebKit.dir\Debug\WebCoreArgumentCodersCurl.o"
19>Link : error : L0039: reference to undefined symbol `WebCore::CookieJarDB::CookieJarDB(WTF::String const&)' in file "WebKitBuild\Source\WebKit\WebKit.dir\Debug\WebCookieManagerCurl.o"
19>Link : error : L0039: reference to undefined symbol `WebCore::CookieJarDB::~CookieJarDB()' in file "WebKitBuild\Source\WebKit\WebKit.dir\Debug\WebCookieManagerCurl.o"
19>Link : error : L0039: reference to undefined symbol `WebCore::NetworkStorageSession::setCookieDatabase(WTF::UniqueRef<WebCore::CookieJarDB>&&) const' in file "WebKitBuild\Source\WebKit\WebKit.dir\Debug\WebCookieManagerCurl.o"
Comment 1 Christopher Reid 2018-02-28 19:00:22 PST 
Created attachment 334794 [details]
Patch
Comment 2 Christopher Reid 2018-02-28 19:06:29 PST 
(In reply to Christopher Reid from comment #0)
> 19>Link : error : L0039: reference to undefined symbol
> `WebCore::CurlProxySettings::operator= (WebCore::CurlProxySettings const&)'
> in file "WebKitBuild\Source\WebKit\WebKit.dir\Debug\WebProcessPool.o"
> 19>Link : error : L0039: reference to undefined symbol
> `WebCore::CurlContext::singleton()' in file
> "WebKitBuild\Source\WebKit\WebKit.dir\Debug\NetworkDataTaskCurl.o"
> 19>Link : error : L0039: reference to undefined symbol
> `WebCore::CurlProxySettings::setUserPass(WTF::String const&, WTF::String
> const&)' in file
> "WebKitBuild\Source\WebKit\WebKit.dir\Debug\NetworkDataTaskCurl.o"
> 19>Link : error : L0039: reference to undefined symbol
> `WebCore::CurlProxySettings::isolatedCopy() const' in file
> "WebKitBuild\Source\WebKit\WebKit.dir\Debug\NetworkProcessCurl.o"
> 19>Link : error : L0039: reference to undefined symbol
> `WebCore::CurlProxySettings::CurlProxySettings(WebCore::CurlProxySettings::
> Mode)' in file
> "WebKitBuild\Source\WebKit\WebKit.dir\Debug\WebCoreArgumentCodersCurl.o"
> 19>Link : error : L0039: reference to undefined symbol
> `WebCore::CurlProxySettings::CurlProxySettings(WebCore::URL const&,
> WTF::String)' in file
> "WebKitBuild\Source\WebKit\WebKit.dir\Debug\WebCoreArgumentCodersCurl.o"
> 19>Link : error : L0039: reference to undefined symbol
> `WebCore::CookieJarDB::CookieJarDB(WTF::String const&)' in file
> "WebKitBuild\Source\WebKit\WebKit.dir\Debug\WebCookieManagerCurl.o"
> 19>Link : error : L0039: reference to undefined symbol
> `WebCore::CookieJarDB::~CookieJarDB()' in file
> "WebKitBuild\Source\WebKit\WebKit.dir\Debug\WebCookieManagerCurl.o"
> 19>Link : error : L0039: reference to undefined symbol
> `WebCore::NetworkStorageSession::setCookieDatabase(WTF::UniqueRef<WebCore::
> CookieJarDB>&&) const' in file
> "WebKitBuild\Source\WebKit\WebKit.dir\Debug\WebCookieManagerCurl.o"

I was mistaken about the CurlProxySettings errors, they don't apply to trunk.
All the other errors occur.
Comment 3 WebKit Commit Bot 2018-03-01 08:59:48 PST 
Comment on attachment 334794 [details]
Patch

Clearing flags on attachment: 334794

Committed r229132: <https://trac.webkit.org/changeset/229132>
Comment 4 WebKit Commit Bot 2018-03-01 08:59:49 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-03-01 09:00:45 PST 
<rdar://problem/38028715>