Bug 183232 – Layout Test accessibility/mac/accessibility-make-first-responder.html is flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Matt Lewis]

The following layout test is flaky on [insert platform]

accessibility/mac/accessibility-make-first-responder.html

Probable cause:

Failed since being added in 

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=accessibility%2Fmac%2Faccessibility-make-first-responder.html

https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r229106%20(3180)/results.html

Diff:
--- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/accessibility/mac/accessibility-make-first-responder-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/accessibility/mac/accessibility-make-first-responder-actual.txt
@@ -6,7 +6,7 @@
 DOM focus
 Window is still the first responder: true
 Accessibility focus
-Window is still the first responder: false
+Window is still the first responder: true
 PASS successfullyParsed is true
 
 TEST COMPLETE

[Matt Lewis]

The platform is currently High Sierra Release WK2

[Nan Wang]

Created attachment 334788 [details]
patch

fix the test

[chris fleizach]

Comment on attachment 334788 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334788&action=review

> LayoutTests/ChangeLog:11
> +

extra new line

> LayoutTests/accessibility/mac/accessibility-make-first-responder.html:62
> +            setTimeout(

setTimeout(function() {

[Nan Wang]

Created attachment 334791 [details]
patch

update

[WebKit Commit Bot]

Comment on attachment 334791 [details]
patch

Clearing flags on attachment: 334791

Committed r229118: <https://trac.webkit.org/changeset/229118>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/38010208>