When the WebContent process doesn't have access to the WindowServer, the scrollbars are always of the overlay type.
<rdar://problem/37793457>
Created attachment 334784 [details] Patch
Comment on attachment 334784 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334784&action=review > Source/WebKit/WebProcess/WebProcess.cpp:222 > + You can revert this change and make the patch smaller! :-)
Build errors: In file included from ./platform/mac/NSScrollerImpDetails.mm:29: ./platform/mac/NSScrollerImpDetails.h:39:17: error: no type named 'optional' in namespace 'std' static std::optional<bool> m_useOverlayScrollbars; ~~~~~^ ./platform/mac/NSScrollerImpDetails.h:39:25: error: expected member name or ';' after declaration specifiers static std::optional<bool> m_useOverlayScrollbars; ~~~~~~~~~~~~~~~~~~~~^ In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource46-mm.mm:1: ./platform/mac/NSScrollerImpDetails.mm:37:36: error: no member named 'm_useOverlayScrollbars' in 'WebCore::ScrollerStyle' std::optional<bool> ScrollerStyle::m_useOverlayScrollbars; ~~~~~~~~~~~~~~~^ 3 errors generated.
Comment on attachment 334784 [details] Patch I think this seems good overall, but fails to build on any of the mac platforms. This might be an SDK difference between Sierra and High Sierra. Likely just a missing include. r- to fix the build.
Created attachment 334821 [details] Patch
Created attachment 334826 [details] Patch
(In reply to Brent Fulgham from comment #5) > Comment on attachment 334784 [details] > Patch > > I think this seems good overall, but fails to build on any of the mac > platforms. This might be an SDK difference between Sierra and High Sierra. > Likely just a missing include. r- to fix the build. Thanks for reviewing! It seems to build on the bots now :)
Comment on attachment 334821 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334821&action=review r=me > Source/WebCore/WebCore.xcodeproj/project.pbxproj:2518 > + 93500F3213FDE3BE0099EC24 /* NSScrollerImpDetails.h in Headers */ = {isa = PBXBuildFile; fileRef = 93500F3113FDE3BE0099EC24 /* NSScrollerImpDetails.h */; settings = {ATTRIBUTES = (Private, ); }; }; Did you change this on purpose? Fine if you did, but sometimes Xcode shuffles things around for arbitrary reasons (and you could revert this to make the patch smaller and easier to apply) > Source/WebKit/WebProcess/WebProcess.cpp:222 > + Please revert this whitespace-only change. > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:65 > +#endif We usually have these conditional includes in a separate area.
Created attachment 334829 [details] Patch
(In reply to Brent Fulgham from comment #9) > Comment on attachment 334821 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=334821&action=review > > r=me > > > Source/WebCore/WebCore.xcodeproj/project.pbxproj:2518 > > + 93500F3213FDE3BE0099EC24 /* NSScrollerImpDetails.h in Headers */ = {isa = PBXBuildFile; fileRef = 93500F3113FDE3BE0099EC24 /* NSScrollerImpDetails.h */; settings = {ATTRIBUTES = (Private, ); }; }; > > Did you change this on purpose? Fine if you did, but sometimes Xcode > shuffles things around for arbitrary reasons (and you could revert this to > make the patch smaller and easier to apply) > > > Source/WebKit/WebProcess/WebProcess.cpp:222 > > + > > Please revert this whitespace-only change. > > > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:65 > > +#endif > > We usually have these conditional includes in a separate area. I have uploaded a modified patch for landing. Thanks for reviewing!
Comment on attachment 334829 [details] Patch Rejecting attachment 334829 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 334829, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/6724526
Committed r229140: <https://trac.webkit.org/changeset/229140/webkit>.