Bug 183212 - [GStreamer] text samples no longer processed
Summary: [GStreamer] text samples no longer processed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-28 06:27 PST by Philippe Normand
Modified: 2018-03-01 01:31 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.08 KB, patch)
2018-02-28 06:30 PST, Philippe Normand 		calvaris: review+
calvaris: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2018-02-28 06:27:45 PST 
Inband subtitles are no longer rendered. Will attach a patch.
Comment 1 Philippe Normand 2018-02-28 06:30:23 PST 
Created attachment 334742 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2018-02-28 23:51:56 PST 
Comment on attachment 334742 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334742&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:986
> +        for (auto track : m_textTracks.values()) {

Nit: you better do auto& instead.
Comment 3 Philippe Normand 2018-03-01 01:30:14 PST 
Committed r229127: <https://trac.webkit.org/changeset/229127>
Comment 4 Radar WebKit Bug Importer 2018-03-01 01:31:39 PST 
<rdar://problem/38019193>