Bug 183189 - Ensure target triple is propagated correctly to DerivedSources.make
Summary: Ensure target triple is propagated correctly to DerivedSources.make
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-27 15:32 PST by Tim Horton
Modified: 2018-02-27 15:46 PST (History)
5 users (show)

See Also:


Attachments
Patch (6.70 KB, patch)
2018-02-27 15:33 PST, Tim Horton
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-02-27 15:32:55 PST
Ensure target triple is propagated correctly to DerivedSources.make
Comment 1 Tim Horton 2018-02-27 15:33:24 PST
Created attachment 334710 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2018-02-27 15:34:04 PST
<rdar://problem/37959694>
Comment 3 mitz 2018-02-27 15:39:28 PST
Comment on attachment 334710 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334710&action=review

> Source/WebCore/Configurations/Base.xcconfig:121
> +LLVM_TARGET_TRIPLE_SUFFIX = $(inherited);

I can easily picture myself trying to be helpful by removing this seemingly-redundant assignment. Can you add a comment explaining why it’s needed?
Comment 4 Tim Horton 2018-02-27 15:40:22 PST
Fair enough :)
Comment 5 Tim Horton 2018-02-27 15:46:02 PST
https://trac.webkit.org/changeset/229081/webkit