[webkitpy] Remove concept of 'future' versions

[Jonathan Bedard]

Remove the idea of 'future' from Mac and iOS versions. Instead, use decrementing version numbers and inserted apple_additions() to handle this.

[Radar WebKit Bug Importer]

<rdar://problem/37958594>

[Jonathan Bedard]

Created attachment 334709 [details]
Patch

[Jonathan Bedard]

Created attachment 334715 [details]
Patch

[Aakash Jain]

Comment on attachment 334715 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334715&action=review

> Tools/Scripts/webkitpy/port/mac.py:78
> +            while temp_version != self.CURRENT_VERSION:

This will become infinite loop if someone incorrectly set self._os_version.major to anything other than 10. Please add an assert to make sure that for macos major version is always 10.

[Aakash Jain]

Comment on attachment 334715 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334715&action=review

Looks good.

> Tools/ChangeLog:3
> +        Remove concept of 'future'

Can make the bug title more descriptive, like "Remove concept of 'future' from TestExpectations".

[Jonathan Bedard]

Created attachment 334718 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 334718 [details]
Patch for landing

Clearing flags on attachment: 334718

Committed r229085: <https://trac.webkit.org/changeset/229085>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Simon Fraser (smfr)]

This bug could have had a more descriptive title.

[Daniel Bates]

(In reply to Simon Fraser (smfr) from comment #9)
> This bug could have had a more descriptive title.

You’re not the only one to point this out. It was pointed out in comment 5.

[Aakash Jain]

I think it was my oversight. I was doing over the shoulder code review with Jonathan and he incorporated all my verbal review comments. I commented about bug title here but forgot to tell Jonathan. He was using webkit-patch command to upload patch so probably didn't notice my bugzilla comment.

[Jonathan Bedard]

Reopening to attach new patch.

[Jonathan Bedard]

Created attachment 334753 [details]
Follow-up fix

[Jonathan Bedard]

(In reply to Jonathan Bedard from comment #13)
> Created attachment 334753 [details]
> Follow-up fix

Missed a non-obvious dependency on future in the factory.

[David Kilzer (:ddkilzer)]

Comment on attachment 334753 [details]
Follow-up fix

View in context: https://bugs.webkit.org/attachment.cgi?id=334753&action=review

r=me

> Tools/ChangeLog:9
> +        The factory also relies off of future in a non-obvious way.

Nit:  "off of" => "on"

[Jonathan Bedard]

Follow-up fix committed <https://trac.webkit.org/changeset/229099>.

[Jonathan Bedard]

Created attachment 334787 [details]
Follow-up fix 2

[Jonathan Bedard]

Created attachment 334789 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 334789 [details]
Patch

Clearing flags on attachment: 334789

Committed r229116: <https://trac.webkit.org/changeset/229116>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.