Bug 183171 - Rename samplePendingBuild to samplePendingBuildRequest
Summary: Rename samplePendingBuild to samplePendingBuildRequest
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-27 12:29 PST by Aakash Jain
Modified: 2018-02-28 13:55 PST (History)
5 users (show)

See Also:

Attachments
Proposed patch (6.62 KB, patch)
2018-02-27 12:31 PST, Aakash Jain 		rniwa: review+
Details | Formatted Diff | Diff
Patch for landing (6.63 KB, patch)
2018-02-28 12:16 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2018-02-27 12:29:28 PST 
Websites/perf.webkit.org/unit-tests/buildbot-syncer-tests.js contains methods samplePendingBuild and samplePendingBuildDeprecated. These are poorly named functions as they actually represent a pending buildrequest. We should rename them to samplePendingBuildRequest and samplePendingBuildRequestDeprecated.
Comment 1 Aakash Jain 2018-02-27 12:31:30 PST 
Created attachment 334700 [details]
Proposed patch
Comment 2 Ryosuke Niwa 2018-02-28 01:50:25 PST 
Comment on attachment 334700 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334700&action=review

> Websites/perf.webkit.org/unit-tests/buildbot-syncer-tests.js:318
> +function samplePendingBuildRequest(buildRequestId, buildTime, builderName)

Should be samplePendingBuildRequests since this function returns a list of build requests
even though it always contains one.
Comment 3 Aakash Jain 2018-02-28 12:16:42 PST 
Created attachment 334757 [details]
Patch for landing
Comment 4 Aakash Jain 2018-02-28 12:17:39 PST 
> Should be samplePendingBuildRequests since this function returns a list of
> build requests even though it always contains one.
ok. Renamed.
Comment 5 WebKit Commit Bot 2018-02-28 13:55:01 PST 
Comment on attachment 334757 [details]
Patch for landing

Clearing flags on attachment: 334757

Committed r229101: <https://trac.webkit.org/changeset/229101>
Comment 6 WebKit Commit Bot 2018-02-28 13:55:03 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-02-28 13:55:42 PST 
<rdar://problem/37999819>