Bug 183159 - Modernize FINALIZE_CODE and peer macros to use __VA_ARGS__ arguments.
Summary: Modernize FINALIZE_CODE and peer macros to use __VA_ARGS__ arguments.
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-26 22:40 PST by Mark Lam
Modified: 2018-02-27 10:10 PST (History)
8 users (show)

See Also:

Attachments
proposed patch. (51.33 KB, patch)
2018-02-26 22:59 PST, Mark Lam 		keith_miller: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2018-02-26 22:40:02 PST 
Patch coming.
Comment 1 Radar WebKit Bug Importer 2018-02-26 22:40:49 PST 
<rdar://problem/37930837>
Comment 2 Mark Lam 2018-02-26 22:59:17 PST 
Created attachment 334674 [details]
proposed patch.
Comment 3 EWS Watchlist 2018-02-26 23:02:14 PST 
Attachment 334674 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:313:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:318:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:322:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:337:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:340:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
Total errors found: 5 in 35 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Keith Miller 2018-02-26 23:05:24 PST 
Comment on attachment 334674 [details]
proposed patch.

r=me.
Comment 5 Mark Lam 2018-02-27 10:10:07 PST 
Thanks for the review.  Landed in r229054:<https://trac.webkit.org/r229054>.