Bug 183148 - Loads for a Document controlled by a Service Worker should not use AppCache
Summary: Loads for a Document controlled by a Service Worker should not use AppCache
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-26 14:00 PST by youenn fablet
Modified: 2018-03-02 10:31 PST (History)
8 users (show)

See Also:

Attachments
Patch (6.66 KB, patch)
2018-02-26 14:06 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (7.43 KB, patch)
2018-02-26 14:16 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (7.71 KB, patch)
2018-02-26 14:35 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (7.71 KB, patch)
2018-02-26 15:01 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (17.68 KB, patch)
2018-02-28 14:05 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (17.76 KB, patch)
2018-02-28 14:39 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-sierra (2.39 MB, application/zip)
2018-02-28 15:24 PST, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.88 MB, application/zip)
2018-02-28 15:39 PST, EWS Watchlist 		no flags Details
Patch (17.93 KB, patch)
2018-02-28 15:54 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-02-26 14:00:55 PST 
According spec, any service worker client matching a service worker registration, be it controlled or not, should stop using app cache.
As a first step, we can disable app cache for any service worker client being controlled by a service worker.
Comment 1 youenn fablet 2018-02-26 14:06:02 PST 
Created attachment 334642 [details]
Patch
Comment 2 youenn fablet 2018-02-26 14:16:09 PST 
Created attachment 334643 [details]
Patch
Comment 3 youenn fablet 2018-02-26 14:35:29 PST 
Created attachment 334644 [details]
Patch
Comment 4 youenn fablet 2018-02-26 15:01:45 PST 
Created attachment 334647 [details]
Patch
Comment 5 youenn fablet 2018-02-28 14:05:00 PST 
Created attachment 334767 [details]
Patch
Comment 6 youenn fablet 2018-02-28 14:39:28 PST 
Created attachment 334771 [details]
Patch
Comment 7 EWS Watchlist 2018-02-28 15:24:27 PST 
Comment on attachment 334771 [details]
Patch

Attachment 334771 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6710776

New failing tests:
http/tests/navigation/error404-goback.html
Comment 8 EWS Watchlist 2018-02-28 15:24:28 PST 
Created attachment 334775 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 9 EWS Watchlist 2018-02-28 15:39:16 PST 
Comment on attachment 334771 [details]
Patch

Attachment 334771 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6710971

New failing tests:
http/tests/navigation/error404-goback.html
Comment 10 EWS Watchlist 2018-02-28 15:39:18 PST 
Created attachment 334777 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 11 youenn fablet 2018-02-28 15:54:12 PST 
Created attachment 334779 [details]
Patch
Comment 12 Chris Dumez 2018-03-02 09:47:52 PST 
Comment on attachment 334779 [details]
Patch

r=me
Comment 13 WebKit Commit Bot 2018-03-02 10:29:47 PST 
Comment on attachment 334779 [details]
Patch

Clearing flags on attachment: 334779

Committed r229181: <https://trac.webkit.org/changeset/229181>
Comment 14 WebKit Commit Bot 2018-03-02 10:29:48 PST 
All reviewed patches have been landed.  Closing bug.
Comment 15 Radar WebKit Bug Importer 2018-03-02 10:31:32 PST 
<rdar://problem/38073116>