Bug 183147 - Fix WebCore includes within WebKitLegacy
Summary: Fix WebCore includes within WebKitLegacy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-26 13:43 PST by Don Olmstead
Modified: 2018-02-26 17:37 PST (History)
8 users (show)

See Also:

Attachments
Patch (19.82 KB, patch)
2018-02-26 13:50 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (19.82 KB, patch)
2018-02-26 14:01 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (18.79 KB, patch)
2018-02-26 15:01 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (18.79 KB, patch)
2018-02-26 15:05 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (19.74 KB, patch)
2018-02-26 15:09 PST, Don Olmstead 		thorton: review+
Details | Formatted Diff | Diff
Patch (21.11 KB, patch)
2018-02-26 15:46 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2018-02-26 13:43:30 PST 
WebKitLegacy uses relative includes for a number of WebCore files. It also uses config.h from WebCore in some places. The includes should all target the copied headers.
Comment 1 Don Olmstead 2018-02-26 13:50:45 PST 
Created attachment 334640 [details]
Patch

Removes all config.h references minus the one in WebKitPrefix.

Corrects all WebCore header includes.
Comment 2 EWS Watchlist 2018-02-26 13:52:23 PST 
Attachment 334640 [details] did not pass style-queue:


ERROR: Source/WebKitLegacy/win/Plugins/PluginStream.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Don Olmstead 2018-02-26 14:01:28 PST 
Created attachment 334641 [details]
Patch

Make style queue happy
Comment 4 Don Olmstead 2018-02-26 15:01:11 PST 
Created attachment 334646 [details]
Patch

Removed an additional include directory that shouldn't be there.
Comment 5 EWS Watchlist 2018-02-26 15:04:24 PST 
Attachment 334646 [details] did not pass style-queue:


ERROR: Source/WebKitLegacy/win/Plugins/PluginStream.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Don Olmstead 2018-02-26 15:05:35 PST 
Created attachment 334648 [details]
Patch
Comment 7 Don Olmstead 2018-02-26 15:09:57 PST 
Created attachment 334649 [details]
Patch

For real this time...
Comment 8 EWS Watchlist 2018-02-26 15:12:09 PST 
Attachment 334649 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
ERROR: Source/WebKitLegacy/win/Plugins/PluginStream.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Tim Horton 2018-02-26 15:34:33 PST 
Comment on attachment 334649 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334649&action=review

Please get it building, but this seems great.

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

Do what the bot says!
Comment 10 Don Olmstead 2018-02-26 15:46:05 PST 
Created attachment 334656 [details]
Patch
Comment 11 WebKit Commit Bot 2018-02-26 17:31:47 PST 
Comment on attachment 334656 [details]
Patch

Clearing flags on attachment: 334656

Committed r229048: <https://trac.webkit.org/changeset/229048>
Comment 12 WebKit Commit Bot 2018-02-26 17:31:49 PST 
All reviewed patches have been landed.  Closing bug.
Comment 13 Radar WebKit Bug Importer 2018-02-26 17:37:22 PST 
<rdar://problem/37924737>