Bug 183145 - [Web Animations] Update the playState implementation
Summary: [Web Animations] Update the playState implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-26 13:22 PST by Antoine Quint
Modified: 2018-02-27 05:01 PST (History)
6 users (show)

See Also:

Attachments
Patch (7.39 KB, patch)
2018-02-26 13:25 PST, Antoine Quint 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2018-02-26 13:22:49 PST 
[Web Animations] Update the playState implementation
Comment 1 Antoine Quint 2018-02-26 13:25:36 PST 
Created attachment 334638 [details]
Patch
Comment 2 Dean Jackson 2018-02-26 13:34:24 PST 
Comment on attachment 334638 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334638&action=review

> Source/WebCore/ChangeLog:10
> +        We update our implementation to match the latest spec text. This does not change WPT test results a lot,

Does it change any of the actual tests? When were they last updated?

> Source/WebCore/ChangeLog:11
> +        but this patch will help getting a significant number of new PASS results when we get around to implement

implement*ing*
Comment 3 Antoine Quint 2018-02-26 13:37:32 PST 
(In reply to Dean Jackson from comment #2)
> Comment on attachment 334638 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=334638&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        We update our implementation to match the latest spec text. This does not change WPT test results a lot,
> 
> Does it change any of the actual tests? When were they last updated?

The tests were updated more recently than our current implementation, so they account for the spec change.

> > Source/WebCore/ChangeLog:11
> > +        but this patch will help getting a significant number of new PASS results when we get around to implement
> 
> implement*ing*

Will fix in commit.
Comment 4 Antoine Quint 2018-02-27 05:00:38 PST 
Committed r229058: <https://trac.webkit.org/changeset/229058>
Comment 5 Radar WebKit Bug Importer 2018-02-27 05:01:26 PST 
<rdar://problem/37938553>