Bug 183142 - [Extra zoom mode] Tweak UA stylesheet to improve legibility of rendered text
Summary: [Extra zoom mode] Tweak UA stylesheet to improve legibility of rendered text
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-26 13:08 PST by Wenson Hsieh
Modified: 2018-02-27 00:06 PST (History)
6 users (show)

See Also:

Attachments
Patch (2.21 KB, patch)
2018-02-26 16:11 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Address review comment (1.42 KB, patch)
2018-02-26 19:00 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-02-26 13:08:06 PST 
<rdar://problem/37912966>
Comment 1 Wenson Hsieh 2018-02-26 16:11:38 PST 
Created attachment 334658 [details]
Patch
Comment 2 Wenson Hsieh 2018-02-26 17:08:52 PST 
Comment on attachment 334658 [details]
Patch

Thanks for the review!
Comment 3 WebKit Commit Bot 2018-02-26 17:32:11 PST 
Comment on attachment 334658 [details]
Patch

Clearing flags on attachment: 334658

Committed r229049: <https://trac.webkit.org/changeset/229049>
Comment 4 WebKit Commit Bot 2018-02-26 17:32:13 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Darin Adler 2018-02-26 18:23:22 PST 
Comment on attachment 334658 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334658&action=review

> Source/WebCore/rendering/RenderThemeIOS.mm:1806
> +    return "* { -webkit-text-size-adjust: auto !important; -webkit-hyphens: auto !important; }";

Should be ASCIILiteral.
Comment 6 Wenson Hsieh 2018-02-26 18:48:06 PST 
Good catch!

Reopening to make this adjustment.
Comment 7 Wenson Hsieh 2018-02-26 19:00:00 PST 
Created attachment 334664 [details]
Address review comment
Comment 8 WebKit Commit Bot 2018-02-27 00:06:45 PST 
Comment on attachment 334664 [details]
Address review comment

Clearing flags on attachment: 334664

Committed r229056: <https://trac.webkit.org/changeset/229056>
Comment 9 WebKit Commit Bot 2018-02-27 00:06:47 PST 
All reviewed patches have been landed.  Closing bug.