[Web Animations] Implement the procedure to set the start time
Created attachment 334632 [details]
Attachment 334632 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] 
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 334632 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=334632&action=review
> + setStartTime(std::nullopt);
Is hold time start time? Why isn't this setHoldTime?
(In reply to Dean Jackson from comment #3)
> Comment on attachment 334632 [details]
> View in context:
> > Source/WebCore/animation/WebAnimation.cpp:211
> > + setStartTime(std::nullopt);
> Is hold time start time? Why isn't this setHoldTime?
Nice catch. This was wrong. As it turns out, in practice, there is always a resolved timeline time so this wouldn't ever occur in a browser context. Will fix in commit.
Committed r229040: <https://trac.webkit.org/changeset/229040>