Bug 183137 – [Web Animations] Implement the procedure to set the start time

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Antoine Quint]

[Web Animations] Implement the procedure to set the start time

[Antoine Quint]

Created attachment 334632 [details]
Patch

[EWS Watchlist]

Attachment 334632 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dean Jackson]

Comment on attachment 334632 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334632&action=review

> Source/WebCore/animation/WebAnimation.cpp:211
> +        setStartTime(std::nullopt);

Is hold time start time? Why isn't this setHoldTime?

[Antoine Quint]

(In reply to Dean Jackson from comment #3)
> Comment on attachment 334632 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=334632&action=review
> 
> > Source/WebCore/animation/WebAnimation.cpp:211
> > +        setStartTime(std::nullopt);
> 
> Is hold time start time? Why isn't this setHoldTime?

Nice catch. This was wrong. As it turns out, in practice, there is always a resolved timeline time so this wouldn't ever occur in a browser context. Will fix in commit.

[Antoine Quint]

Committed r229040: <https://trac.webkit.org/changeset/229040>

[Radar WebKit Bug Importer]

<rdar://problem/37913271>