Bug 183103 - [build.webkit.org] unit-tests fail if buildbot 0.8.6p1 is not installed locally
Summary: [build.webkit.org] unit-tests fail if buildbot 0.8.6p1 is not installed locally
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
Keywords: InRadar
Depends on:
Reported: 2018-02-24 15:57 PST by Aakash Jain
Modified: 2018-02-25 10:39 PST (History)
5 users (show)

See Also:

Proposed patch (1.49 KB, patch)
2018-02-24 16:02 PST, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2018-02-24 15:57:48 PST
After https://trac.webkit.org/changeset/225534/webkit added import statements, unit-tests requires that buildbot 0.8.6p1 in installed locally. If another buildbot version is installed locally, the tests fails which a confusing error like below.

Traceback (most recent call last):
  File "./steps_unittest.py", line 12, in <module>
    from steps import (CheckOutSource, Run32bitJSCTests, RunAndUploadPerfTests, RunBenchmarkTests,
  File "/Users/aakash_jain/code1/OpenSource/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py", line 100, in <module>
    class CheckOutSource(source.SVN):
AttributeError: 'module' object has no attribute 'SVN'

Earlier webkitpy used to take care of buildbot packages in background. We stop remove these extra import statements, unless we have a better need to import these explicitly.
Comment 1 Aakash Jain 2018-02-24 16:02:18 PST
Created attachment 334567 [details]
Proposed patch
Comment 2 Aakash Jain 2018-02-24 16:08:35 PST
The following code forces to use buildbot from webkitpy.thirdparty.autoinstalled : 

So, if we import any buildbot module before executing above code, they will be directly imported from locally installed buildbot package.
Comment 3 WebKit Commit Bot 2018-02-25 10:38:42 PST
Comment on attachment 334567 [details]
Proposed patch

Clearing flags on attachment: 334567

Committed r228977: <https://trac.webkit.org/changeset/228977>
Comment 4 WebKit Commit Bot 2018-02-25 10:38:43 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-02-25 10:39:21 PST