Bug 183103 – [build.webkit.org] unit-tests fail if buildbot 0.8.6p1 is not installed locally

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

After https://trac.webkit.org/changeset/225534/webkit added import statements, unit-tests requires that buildbot 0.8.6p1 in installed locally. If another buildbot version is installed locally, the tests fails which a confusing error like below.

Traceback (most recent call last):
  File "./steps_unittest.py", line 12, in <module>
    from steps import (CheckOutSource, Run32bitJSCTests, RunAndUploadPerfTests, RunBenchmarkTests,
  File "/Users/aakash_jain/code1/OpenSource/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py", line 100, in <module>
    class CheckOutSource(source.SVN):
AttributeError: 'module' object has no attribute 'SVN'

Earlier webkitpy used to take care of buildbot packages in background. We stop remove these extra import statements, unless we have a better need to import these explicitly.

[Aakash Jain]

Created attachment 334567 [details]
Proposed patch

[Aakash Jain]

The following code forces to use buildbot from webkitpy.thirdparty.autoinstalled : 
https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py#L38

So, if we import any buildbot module before executing above code, they will be directly imported from locally installed buildbot package.

[WebKit Commit Bot]

Comment on attachment 334567 [details]
Proposed patch

Clearing flags on attachment: 334567

Committed r228977: <https://trac.webkit.org/changeset/228977>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/37875494>