Bug 183100 - [Extra zoom mode] Implement additional SPI for adjusting viewport shrink-to-fit behavior
Summary: [Extra zoom mode] Implement additional SPI for adjusting viewport shrink-to-f...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-23 21:39 PST by Wenson Hsieh
Modified: 2019-05-03 19:21 PDT (History)
6 users (show)

See Also:

Attachments
Patch (57.46 KB, patch)
2018-02-23 22:55 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Fix macOS builds (57.45 KB, patch)
2018-02-24 13:10 PST, Wenson Hsieh 		thorton: review+
Details | Formatted Diff | Diff
Patch for landing (60.67 KB, patch)
2018-02-27 08:04 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-02-23 21:39:23 PST 
<rdar://problem/37840987>
Comment 1 Wenson Hsieh 2018-02-23 22:55:27 PST 
Created attachment 334561 [details]
Patch
Comment 2 Wenson Hsieh 2018-02-24 13:10:48 PST 
Created attachment 334565 [details]
Fix macOS builds
Comment 3 Tim Horton 2018-02-26 14:08:19 PST 
Comment on attachment 334565 [details]
Fix macOS builds

View in context: https://bugs.webkit.org/attachment.cgi?id=334565&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:2509
> +- (WebCore::FloatSize)activeMinimumLayoutSize:(const CGRect&)bounds outViewSize:(WebCore::FloatSize&)viewSize

This is a little ugly (the out arg), but I’m not sure what else to do.
Comment 4 Wenson Hsieh 2018-02-26 14:10:59 PST 
(In reply to Tim Horton from comment #3)
> Comment on attachment 334565 [details]
> Fix macOS builds
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=334565&action=review
> 
> > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:2509
> > +- (WebCore::FloatSize)activeMinimumLayoutSize:(const CGRect&)bounds outViewSize:(WebCore::FloatSize&)viewSize
> 
> This is a little ugly (the out arg), but I’m not sure what else to do.

An alternative is to return the sizes in a struct — I'll make this tweak.
Comment 5 Wenson Hsieh 2018-02-27 08:04:56 PST 
Created attachment 334690 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2018-02-27 09:16:38 PST 
Comment on attachment 334690 [details]
Patch for landing

Clearing flags on attachment: 334690

Committed r229063: <https://trac.webkit.org/changeset/229063>