RESOLVED FIXED 183100
[Extra zoom mode] Implement additional SPI for adjusting viewport shrink-to-fit behavior 
https://bugs.webkit.org/show_bug.cgi?id=183100
Summary [Extra zoom mode] Implement additional SPI for adjusting viewport shrink-to-f...
Wenson Hsieh
Reported 2018-02-23 21:39:23 PST
<rdar://problem/37840987>
Attachments
Patch (57.46 KB, patch)
2018-02-23 22:55 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Fix macOS builds (57.45 KB, patch)
2018-02-24 13:10 PST, Wenson Hsieh 		thorton: review+
DetailsFormatted DiffDiff
Patch for landing (60.67 KB, patch)
2018-02-27 08:04 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2018-02-23 22:55:27 PST
Created attachment 334561 [details] Patch
Wenson Hsieh
Comment 2 2018-02-24 13:10:48 PST
Created attachment 334565 [details] Fix macOS builds
Tim Horton
Comment 3 2018-02-26 14:08:19 PST
Comment on attachment 334565 [details] Fix macOS builds View in context: https://bugs.webkit.org/attachment.cgi?id=334565&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:2509 > +- (WebCore::FloatSize)activeMinimumLayoutSize:(const CGRect&)bounds outViewSize:(WebCore::FloatSize&)viewSize This is a little ugly (the out arg), but I’m not sure what else to do.
Wenson Hsieh
Comment 4 2018-02-26 14:10:59 PST
(In reply to Tim Horton from comment #3) > Comment on attachment 334565 [details] > Fix macOS builds > > View in context: > https://bugs.webkit.org/attachment.cgi?id=334565&action=review > > > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:2509 > > +- (WebCore::FloatSize)activeMinimumLayoutSize:(const CGRect&)bounds outViewSize:(WebCore::FloatSize&)viewSize > > This is a little ugly (the out arg), but I’m not sure what else to do. An alternative is to return the sizes in a struct — I'll make this tweak.
Wenson Hsieh
Comment 5 2018-02-27 08:04:56 PST
Created attachment 334690 [details] Patch for landing
WebKit Commit Bot
Comment 6 2018-02-27 09:16:38 PST
Comment on attachment 334690 [details] Patch for landing Clearing flags on attachment: 334690 Committed r229063: <https://trac.webkit.org/changeset/229063>
Note You need to log in before you can comment on or make changes to this bug.