Tracking a FIXME in CookieJarDB.cpp: // FIXME: Need to check that a domain doesn't a set cookie for a tld when wincairo supports PSL
Created attachment 337196 [details] Patch
Attachment 337196 [details] did not pass style-queue: ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:29: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:98: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:43: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:47: bytes_consumed is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:49: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:48: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:49: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:50: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:51: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:52: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:53: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:54: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:55: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:56: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:58: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:59: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:60: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:61: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:61: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:63: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:63: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:65: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:65: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:66: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:70: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:71: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:71: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:76: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:77: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:82: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:82: return_value is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:83: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:84: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:85: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:86: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:87: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:90: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:91: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:94: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:97: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:98: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:108: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:109: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:112: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:114: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:115: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:116: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:117: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:118: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:120: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:121: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:122: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:122: is_last_char_in_label is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:123: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:123: is_match is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:124: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:132: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:134: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:135: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:136: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:137: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:151: is_last_char_in_label is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:152: is_match is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:155: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:156: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:157: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:158: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:159: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:160: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:161: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:162: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:164: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:166: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:168: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:169: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:170: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:171: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:174: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:175: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:176: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:177: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:181: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:188: temp_pos is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:195: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:196: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:197: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:200: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:201: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:205: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:206: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:207: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:207: key_length is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:208: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:209: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:210: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:211: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:211: key_end is incorrectly named. Don't use underscores in your identifier names. [readability/naming/undersc ores] [4] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:212: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:214: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:216: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:217: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:218: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:219: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.cpp:222: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/curl/PublicSuffixCurl.cpp:34: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/curl/PublicSuffixCurl.cpp:54: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/WebCore/platform/curl/PublicSuffixCurl.cpp:56: domain_next is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/curl/normalize_psl.py:83: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Source/WebCore/platform/curl/normalize_psl.py:89: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Source/WebCore/platform/curl/normalize_psl.py:102: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Source/WebCore/platform/curl/normalize_psl.py:149: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Source/WebCore/platform/curl/normalize_psl.py:153: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Source/WebCore/platform/curl/normalize_psl.py:172: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Source/WebCore/platform/Curl.cmake:7: Alphabetical sorting problem. "platform/curl/LookupStringInFixedSet.cpp" should be before "platform/curl/PublicSuffixCurl.cpp". [list/order] [5] ERROR: Source/WebCore/platform/URL.cpp:440: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:36: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:36: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:37: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:37: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:38: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:39: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:40: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:40: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:41: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:41: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:42: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:42: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:51: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:57: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:58: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:59: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:59: key_length is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:101: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:102: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:103: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:104: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:105: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:107: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:108: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:109: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:110: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:111: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:112: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:114: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:115: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:116: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:117: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:118: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:119: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:121: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:123: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:124: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:125: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:126: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:127: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:128: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:129: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:130: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:131: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:132: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:133: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:134: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:135: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:137: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:139: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:140: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:141: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:142: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:143: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:144: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:145: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:146: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:147: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:148: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:149: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:151: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:152: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:153: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:154: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:154: pos_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:156: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:157: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:158: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:158: end_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:160: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:161: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:162: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:163: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:163: pos_is_label_character_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/curl/LookupStringInFixedSet.h:166: One space before end of line comments [whitespace/comments] [5] Total errors found: 194 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 337202 [details] Patch
Attachment 337202 [details] did not pass style-queue: ERROR: Source/WebCore/platform/curl/PublicSuffixCurl.cpp:39: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sorry for that buildbot wall of text. This change uses files from the chromium project. > * platform/curl/LookupStringInFixedSet.cpp: Added. https://cs.chromium.org/chromium/src/net/base/lookup_string_in_fixed_set.cc?q=lookup_string_&sq=package:chromium&l=1 > * platform/curl/LookupStringInFixedSet.h: Added. https://cs.chromium.org/chromium/src/net/base/lookup_string_in_fixed_set.h?q=lookup_st&sq=package:chromium&l=1 > * platform/curl/make_dafsa.py: Added. https://cs.chromium.org/chromium/src/net/tools/dafsa/make_dafsa.py?q=make_dafsa&sq=package:chromium&dr=C&l=421 > * platform/curl/normalize_psl.py: Added. Based on https://cs.chromium.org/chromium/src/net/tools/tld_cleanup/tld_cleanup.cc?q=tld_&sq=package:chromium&l=1 Chromium's BSD license file: https://cs.chromium.org/chromium/src/LICENSE?q=license&sq=package:chromium&l=1 Right now I have the feature enabled but needs a new release of WinCairoRequirements before landing. I was wanting to wait on review feedback first.
Comment on attachment 337202 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337202&action=review > Source/WebCore/platform/URL.cpp:440 > + return { }; std::nullopt > Source/WebCore/platform/URL.cpp:441 > + return std::optional<StringView> {StringView(encodedHostName.data(), encodedHostName.size())}; encodedHostName goes out of scope with this. Why not just return an optional<UCharBuffer>? Also, if we know it's ASCII, why don't we just make it an LCharBuffer? Also, appendEncodedHostname should return a std::optional<something> instead of a bool and returning by reference. > Source/WebCore/platform/curl/PublicSuffixCurl.cpp:39 > +#include "PSLDafsa.cpp" Let's not.
Comment on attachment 337202 [details] Patch Attachment 337202 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7207567 New failing tests: imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/window-name-after-cross-origin-aux-frame-navigation.sub.html fast/dom/HTMLAnchorElement/set-href-attribute-prevents-rebase.html imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/window-name-after-cross-origin-sub-frame-navigation.sub.html imported/w3c/web-platform-tests/html/browsers/origin/relaxing-the-same-origin-restriction/document_domain_setter.html fast/dom/HTMLAnchorElement/set-href-attribute-hostname.html fast/dom/DOMURL/set-href-attribute-hostname.html imported/w3c/web-platform-tests/url/url-setters.html http/tests/security/window-name-after-cross-origin-main-frame-navigation.html http/tests/dom/set-document-location-hostname-to-accepted-values.html
Created attachment 337224 [details] Archive of layout-test-results from ews114 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6
I'm not sure I like introducing all this Chromium-style code into WebKit. I'm not opposed to the use of a DFA of some sort for this, though. There still needs to be some kind of input containing a list of public suffixes, though, right? Where is that here?
> Comment on attachment 337202 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=337202&action=review > > > Source/WebCore/platform/URL.cpp:440 > > + return { }; > > std::nullopt > Will do. > > Source/WebCore/platform/URL.cpp:441 > > + return std::optional<StringView> {StringView(encodedHostName.data(), encodedHostName.size())}; > > encodedHostName goes out of scope with this. Why not just return an > optional<UCharBuffer>? > Also, if we know it's ASCII, why don't we just make it an LCharBuffer? > Also, appendEncodedHostname should return a std::optional<something> instead > of a bool and returning by reference. Ah right, I should have realized StringView doesn't copy. Thanks for catching that. I'll look at returning LCharBuffers for those functions. > > Source/WebCore/platform/curl/PublicSuffixCurl.cpp:39 > > +#include "PSLDafsa.cpp" > > Let's not. I'll do something else here.
(In reply to Alex Christensen from comment #9) > I'm not sure I like introducing all this Chromium-style code into WebKit. > I'm not opposed to the use of a DFA of some sort for this, though. > There still needs to be some kind of input containing a list of public suffixes, > though, right? Where is that here? We were planning on packaging it in with WinCairoRequirements. When we move WinCairoRequirements to use vcpkg I feel that the psl file is easier to maintain there. Currently, WinCairoRequirements will package the latest psl file. vcpkg WinCairoRequirements branch: https://github.com/WebKitForWindows/WinCairoRequirements/commit/fa64fbd26d27d2d183e0d75cd99086ce42bcc68f master WinCairoRequirements: https://github.com/WebKitForWindows/WinCairoRequirements/commit/98669bb28d0abd2be1d1ba6b1c1ae2b08b1e4db0
Created attachment 338381 [details] Updated patch I ended up keeping a return of UCharBuffer instead of an LCharBuffer as there was a case where hostnames over 2048 characters won't get encoded to punycode. I also tried to modernize chromium's lookup code a bit. The dafsa data is now using a static NeverDestroyed vector instead of a raw array. Also this is a bit out of scope from these changes but one thing I noticed is that URL.cpp is still using the deprecated uidna_IDNToASCII for encoding hostnames. Is there a reason it wasn't updated to use IDN2008 yet? I tried it out in trunk and setting window.location.host or window.location.href to a hostname containing ß can resolve to different domains.
Comment on attachment 338381 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=338381&action=review > Source/WebCore/platform/URL.cpp:411 > + return std::optional<UCharBuffer> {buffer}; This should have a WTFMove. > Source/WebCore/platform/URL.cpp:429 > + return std::optional<UCharBuffer> {buffer}; ditto.
Created attachment 352118 [details] Patch We decided to switch to using libpsl for WinCairo's public suffix implementation now that it compiles on Windows. It is licensed under MIT and uses chromium sources licensed under BSD-3.
Comment on attachment 352118 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352118&action=review This is great work! I just think there's an issue with the finding of it since the bot is saying it can't find the library. > Source/cmake/FindLibPSL.cmake:37 > + NAMES libpsl Should this just be psl? I see psl.lib in the WinCairoRequirements.
Created attachment 352132 [details] Patch WinCairo build fix
Comment on attachment 352132 [details] Patch Cool!
Comment on attachment 352132 [details] Patch Clearing flags on attachment: 352132 Committed r237118: <https://trac.webkit.org/changeset/237118>
All reviewed patches have been landed. Closing bug.
<rdar://problem/45273475>
It looks like some of these imported mac test cases are failing on GTK Here's the result of my run: > **FAIL** PublicSuffix.IsPublicSuffix > > ../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:81 > Value of: isPublicSuffix("COM") > Actual: false > Expected: true > > **FAIL** PublicSuffix.TopPrivatelyControlledDomain > > ../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:156 > Expected equality of these values: > utf16String(u"\u6803\u6728.jp") > Which is: xn--4pvxs.jp > topPrivatelyControlledDomain(utf16String(u"\u6803\u6728.jp")) > Which is: > > > ../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:177 > Expected equality of these values: > String("example.com") > Which is: example.com > topPrivatelyControlledDomain("ExamPle.com") > Which is: ExamPle.com > > > ../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:178 > Expected equality of these values: > String("example.com") > Which is: example.com > topPrivatelyControlledDomain("SUB.dOmain.ExamPle.com") > Which is: ExamPle.com > > > ../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:179 > Expected equality of these values: > String("localhost") > Which is: localhost > topPrivatelyControlledDomain("localhost") > Which is: > > > ../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:180 > Expected equality of these values: > String("localhost") > Which is: localhost > topPrivatelyControlledDomain("LocalHost") > Which is: > > > ../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:181 > Expected equality of these values: > String("åäö") > Which is: åäö > topPrivatelyControlledDomain("åäö") > Which is: > > > ../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:182 > Expected equality of these values: > String("ÅÄÖ") > Which is: à > à > à > topPrivatelyControlledDomain("ÅÄÖ") > Which is:
CC: claudio for failing public suffix tests
(In reply to Michael Catanzaro from comment #22) > CC: claudio for failing public suffix tests For libsoup's libpsl-powered public suffix api we need 2.63.1, but currently we're depending on a much older version and jhbuild fetches 2.57.1. When I have some time I'll check if bumping libsoup's version fixes these tests.
(In reply to Christopher Reid from comment #21) > It looks like some of these imported mac test cases are failing on GTK > > Here's the result of my run: > > > **FAIL** PublicSuffix.IsPublicSuffix > > > > ../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:81 > > Value of: isPublicSuffix("COM") > > Actual: false > > Expected: true This is failing because we don't downcase the string before passing it to libsoup. Libsoup expects it to be downcased (it's not documented anywhere for some reason but so it is). > > > > **FAIL** PublicSuffix.TopPrivatelyControlledDomain > > > > ../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:156 > > Expected equality of these values: > > utf16String(u"\u6803\u6728.jp") > > Which is: xn--4pvxs.jp > > topPrivatelyControlledDomain(utf16String(u"\u6803\u6728.jp")) > > Which is: 栃木.jp is in the public-domain suffix list, from what I understand this is not a registrable domain (it's a public one). So I think this test is wrong and should be removed. > > > > > > ../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:177 > > Expected equality of these values: > > String("example.com") > > Which is: example.com > > topPrivatelyControlledDomain("ExamPle.com") > > Which is: ExamPle.com > > Same as first one. > > > > ../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:178 > > Expected equality of these values: > > String("example.com") > > Which is: example.com > > topPrivatelyControlledDomain("SUB.dOmain.ExamPle.com") > > Which is: ExamPle.com > > > > Ditto. > > ../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:179 > > Expected equality of these values: > > String("localhost") > > Which is: localhost > > topPrivatelyControlledDomain("localhost") > > Which is: > > > > > > ../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:180 > > Expected equality of these values: > > String("localhost") > > Which is: localhost > > topPrivatelyControlledDomain("LocalHost") > > Which is: > > > > These two are special-cased in the Mac implementation. We should do the same. > > ../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:181 > > Expected equality of these values: > > String("åäö") > > Which is: åäö > > topPrivatelyControlledDomain("åäö") > > Which is: > > > > > > ../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:182 > > Expected equality of these values: > > String("ÅÄÖ") > > Which is: à > > à > > à > > topPrivatelyControlledDomain("ÅÄÖ") > > Which is: The error checking in the soup implementation is wrong so that's why these fail. Fixing those raises a few more failures. I'll file a new bug for this.