Bug 183055 - CacheStorage::Engine::Caches::writeRecord is not always calling the completion handler
Summary: CacheStorage::Engine::Caches::writeRecord is not always calling the completio...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-22 12:47 PST by youenn fablet
Modified: 2018-02-22 14:51 PST (History)
7 users (show)

See Also:

Attachments
Patch (7.94 KB, patch)
2018-02-22 13:13 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-02-22 12:47:38 PST 
CacheStorage::Engine::Caches::writeRecord is not always calling the completion handler
Comment 1 youenn fablet 2018-02-22 12:52:57 PST 
We should really move all CacheStorage callbacks to CompletionHandler to catch these potential issues.
In the meantime, there is an issue with Caches::writeRecord in private browsing mode and when network cache is not calling back the blob.
Comment 2 youenn fablet 2018-02-22 13:13:55 PST 
Created attachment 334471 [details]
Patch
Comment 3 WebKit Commit Bot 2018-02-22 14:50:24 PST 
Comment on attachment 334471 [details]
Patch

Clearing flags on attachment: 334471

Committed r228935: <https://trac.webkit.org/changeset/228935>
Comment 4 WebKit Commit Bot 2018-02-22 14:50:26 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-02-22 14:51:33 PST 
<rdar://problem/37803382>