Bug 183044 – [WinCairo] Add WebKit Shared/win files for wincairo webkit

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Yousuke Kimoto]

Add files in Shared/Win for wincairo webkit. (Event files for wincairo webkit are handled in Bug 183043).
In this ticket, the following files are added:
- WebKit/Shared/win/ArgumentCodersWin.cpp
- WebKit/Shared/win/ArgumentCodersWin.h
- WebKit/Shared/win/ChildProcessMainWin.cpp
- WebKit/Shared/win/ProcessExecutablePathWin.cpp
- WebKit/Shared/win/WebErrorsWin.cpp

[Yousuke Kimoto]

Created attachment 334521 [details]
Patch

[Don Olmstead]

Comment on attachment 334521 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334521&action=review

Think this about ready to go. Just need to change that stale call.

> Source/WebKit/Shared/win/ProcessExecutablePathWin.cpp:62
> +#if ENABLE(DATABASE_PROCESS)
> +String executablePathOfDatabaseProcess()
> +{
> +    return findWebKitProcess("WebKitDatabaseProcess");
> +}
> +#endif

This is stale. There is no more Database Process its Storage Process. There's no ENABLE around it either.

String executablePathOfStorageProcess()
{
    return findWebKitProcess("WebKitStorageProcess");
}

> Source/WebKit/Shared/win/WebErrorsWin.cpp:41
> +    // FIXME: Need ChickenCat to include CFNetwork/CFURLError.h to get these values
> +    // Alternatively, we could create our own error domain/codes.

ChickenCat?

[Don Olmstead]

(In reply to Don Olmstead from comment #2)
> Comment on attachment 334521 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=334521&action=review
> 
> Think this about ready to go. Just need to change that stale call.
> 
> > Source/WebKit/Shared/win/ProcessExecutablePathWin.cpp:62
> > +#if ENABLE(DATABASE_PROCESS)
> > +String executablePathOfDatabaseProcess()
> > +{
> > +    return findWebKitProcess("WebKitDatabaseProcess");
> > +}
> > +#endif
> 
> This is stale. There is no more Database Process its Storage Process.
> There's no ENABLE around it either.
> 
> String executablePathOfStorageProcess()
> {
>     return findWebKitProcess("WebKitStorageProcess");
> }
> 
> > Source/WebKit/Shared/win/WebErrorsWin.cpp:41
> > +    // FIXME: Need ChickenCat to include CFNetwork/CFURLError.h to get these values
> > +    // Alternatively, we could create our own error domain/codes.
> 
> ChickenCat?

Appears ChickenCat is something that was copy pasted from a file in WebKitLegacy. I think we can just delete this as we don't have any plans to use CFNetwork on WinCairo

[Yousuke Kimoto]

Comment on attachment 334521 [details]
Patch

Don, thanks.
I'll reconfirm those files you mentioned.

[Yousuke Kimoto]

Created attachment 334998 [details]
Patch

[Alex Christensen]

Comment on attachment 334998 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334998&action=review

> Source/WebKit/Shared/win/ProcessExecutablePathWin.cpp:5
> + *

extra space

> Source/WebKit/Shared/win/ProcessExecutablePathWin.cpp:40
> +    //        Currently "processName" is just returned.

This comment line has strange spacing and is not adding anything to the code.

[Fujii Hironori]

Created attachment 337149 [details]
Patch

Thank you, Alex.

* Removed unused files ArgumentCodersWin.* and ProcessExecutablePathWin.cpp
* ChildProcessMainWin.cpp: Handle `-processIdentifier` switch

[WebKit Commit Bot]

Comment on attachment 337149 [details]
Patch

Clearing flags on attachment: 337149

Committed r230260: <https://trac.webkit.org/changeset/230260>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/39177611>