Bug 183021 – AX: AOM: Dispatch accessiblesetvalue event

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Nan Wang]

Spec: https://wicg.github.io/aom/spec/phase2.html
Support new event type: 
interface AccessibleSetValueEvent : Event {
    attribute DOMString value;
};

[Radar WebKit Bug Importer]

<rdar://problem/37764242>

[Nan Wang]

Created attachment 334758 [details]
patch

[chris fleizach]

Comment on attachment 334758 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334758&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:2172
> +    if (!canSetValueAttribute())

do you think we want to check this here? are there going to be cases where this doesn't match up? technically nothing stopping someone from responding to a set value event on any element right?

> Source/WebCore/accessibility/events/AccessibleSetValueEvent.cpp:40
> +{

seems like this should just be in the header

[Nan Wang]

Comment on attachment 334758 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334758&action=review

>> Source/WebCore/accessibility/AccessibilityObject.cpp:2172
>> +    if (!canSetValueAttribute())
> 
> do you think we want to check this here? are there going to be cases where this doesn't match up? technically nothing stopping someone from responding to a set value event on any element right?

I did this because from the spec this event is limited to some roles:
"combobox", "scrollbar", "slider", "textbox"

[Nan Wang]

working on fixing the builds

[Nan Wang]

Created attachment 334764 [details]
patch

update

[Nan Wang]

Created attachment 334769 [details]
patch

Tried to fix the build

[Nan Wang]

Created attachment 334774 [details]
patch

Updated test to account for canSetValueAttribute()

[WebKit Commit Bot]

Comment on attachment 334774 [details]
patch

Clearing flags on attachment: 334774

Committed r229112: <https://trac.webkit.org/changeset/229112>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.