Bug 183017 – Templatize SVGAnimatedType

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Said Abou-Hallawa]

This is a code refactoring, It is part of the patch of https://bugs.webkit.org/show_bug.cgi?id=168586. The goal to have SVGAnimatedType be type independent. The appropriate method of this template will be implicitly instantiated based to the type of the animated attribute(s).

[Said Abou-Hallawa]

Created attachment 334415 [details]
Patch

[EWS Watchlist]

Comment on attachment 334415 [details]
Patch

Attachment 334415 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6615190

New failing tests:
svg/text/text-altglyph-01-b.svg
svg/W3C-SVG-1.1/text-altglyph-01-b.svg

[EWS Watchlist]

Created attachment 334422 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[Said Abou-Hallawa]

Created attachment 334977 [details]
Patch

[Said Abou-Hallawa]

Created attachment 334978 [details]
Patch

[Said Abou-Hallawa]

Created attachment 335008 [details]
Patch

[Said Abou-Hallawa]

Can one of the reviewers in the CC list have a look at this bug? Please let me know if a more detailed description of the fix can move this patch forward.

[Dean Jackson]

Comment on attachment 335008 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335008&action=review

> Source/WebCore/svg/SVGAnimatedAngle.cpp:83
> +    const auto& fromAngleAndEnumeration = (m_animationElement->animationMode() == ToAnimation ? animated : from)->as<std::pair<SVGAngleValue, unsigned>>();

Given that you have to call this test so often, maybe it could be a helper?

m_animationElement->isToAnimation() ? animated : from

[Said Abou-Hallawa]

Comment on attachment 335008 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335008&action=review

>> Source/WebCore/svg/SVGAnimatedAngle.cpp:83
>> +    const auto& fromAngleAndEnumeration = (m_animationElement->animationMode() == ToAnimation ? animated : from)->as<std::pair<SVGAngleValue, unsigned>>();
> 
> Given that you have to call this test so often, maybe it could be a helper?
> 
> m_animationElement->isToAnimation() ? animated : from

I will include this change in the next patch.

[WebKit Commit Bot]

Comment on attachment 335008 [details]
Patch

Clearing flags on attachment: 335008

Committed r229417: <https://trac.webkit.org/changeset/229417>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/38268664>