Bug 183012 - Document.open() cancels existing provisional load but not navigation policy check
Summary: Document.open() cancels existing provisional load but not navigation policy c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 180568
  Show dependency tree / graph
 
Reported: 2018-02-21 12:03 PST by Chris Dumez
Modified: 2018-02-22 10:29 PST (History)
12 users (show)

See Also:

Attachments
WIP Patch (3.82 KB, patch)
2018-02-21 12:05 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-sierra (2.21 MB, application/zip)
2018-02-21 13:10 PST, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews117 for mac-sierra (3.05 MB, application/zip)
2018-02-21 13:41 PST, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews205 for win-future (11.51 MB, application/zip)
2018-02-21 14:08 PST, EWS Watchlist 		no flags Details
Patch (6.46 KB, patch)
2018-02-21 14:53 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-02-21 12:03:41 PST 
Document.open() cancels existing provisional load but not navigation policy check.

Now that policy decision can be made asynchronously, Document.open() can be called while we're awaiting the policy decision for a navigation. However, Document.open() currently only cancels pending provisional loads, after we've received the navigation policy decision. We need to make sure it cancels pending navigation policy decisions as well.
Comment 1 Radar WebKit Bug Importer 2018-02-21 12:04:06 PST 
<rdar://problem/37755831>
Comment 2 Chris Dumez 2018-02-21 12:05:26 PST 
Created attachment 334401 [details]
WIP Patch
Comment 3 EWS Watchlist 2018-02-21 13:10:13 PST 
Comment on attachment 334401 [details]
WIP Patch

Attachment 334401 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6612870

New failing tests:
fast/dom/Document/open-with-pending-load-async-policy.html
Comment 4 EWS Watchlist 2018-02-21 13:10:15 PST 
Created attachment 334408 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 5 EWS Watchlist 2018-02-21 13:41:08 PST 
Comment on attachment 334401 [details]
WIP Patch

Attachment 334401 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6613134

New failing tests:
fast/dom/Document/open-with-pending-load-async-policy.html
Comment 6 EWS Watchlist 2018-02-21 13:41:09 PST 
Created attachment 334411 [details]
Archive of layout-test-results from ews117 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 7 EWS Watchlist 2018-02-21 14:08:26 PST 
Comment on attachment 334401 [details]
WIP Patch

Attachment 334401 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/6613647

New failing tests:
fast/dom/Document/open-with-pending-load-async-policy.html
Comment 8 EWS Watchlist 2018-02-21 14:08:37 PST 
Created attachment 334412 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 9 Chris Dumez 2018-02-21 14:53:29 PST 
Created attachment 334418 [details]
Patch
Comment 10 WebKit Commit Bot 2018-02-22 10:29:31 PST 
Comment on attachment 334418 [details]
Patch

Clearing flags on attachment: 334418

Committed r228922: <https://trac.webkit.org/changeset/228922>
Comment 11 WebKit Commit Bot 2018-02-22 10:29:32 PST 
All reviewed patches have been landed.  Closing bug.