RESOLVED FIXED 183002
[GStreamer] HTTP totalBytes query returns 0 after seeking (sometimes) 
https://bugs.webkit.org/show_bug.cgi?id=183002
Summary [GStreamer] HTTP totalBytes query returns 0 after seeking (sometimes)
Philippe Normand
Reported 2018-02-21 07:31:01 PST
The size attribute is reset when the element performs seeks, I don't see why that would make sense. Also it's useless to handle the DURATION query if the appsrc size is correctly set (once) in the first place.
Attachments
Patch (4.79 KB, patch)
2018-02-21 07:35 PST, Philippe Normand 		calvaris: review+
calvaris: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2018-02-21 07:35:47 PST
Created attachment 334375 [details] Patch
Enrique Ocaña
Comment 2 2018-02-22 01:11:54 PST
Comment on attachment 334375 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334375&action=review Apart from the nitpick below, I don't see anything wrong with the patch. > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:86 > + gboolean haveSize; This attribute is only for internal usage and doesn't interact with Glib. Why not using a C++ bool type, like for "paused" or "isSeeking"?
Xabier Rodríguez Calvar
Comment 3 2018-02-22 01:14:09 PST
Comment on attachment 334375 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334375&action=review >> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:86 >> + gboolean haveSize; > > This attribute is only for internal usage and doesn't interact with Glib. Why not using a C++ bool type, like for "paused" or "isSeeking"? I was going to mention exactly the same thing :)
Philippe Normand
Comment 4 2018-02-23 02:07:00 PST
Committed r228945: <https://trac.webkit.org/changeset/228945>
Radar WebKit Bug Importer
Comment 5 2018-02-23 02:07:20 PST
<rdar://problem/37820322>
Note You need to log in before you can comment on or make changes to this bug.