Bug 182988 - VTTCue constructor should use 'double' type for startTime / endTime
Summary: VTTCue constructor should use 'double' type for startTime / endTime
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-20 16:12 PST by Chris Dumez
Modified: 2018-02-21 11:37 PST (History)
5 users (show)

See Also:

Attachments
Patch (5.83 KB, patch)
2018-02-20 16:30 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (8.17 KB, patch)
2018-02-20 16:38 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-02-20 16:12:59 PST 
VTTCue constructor should use 'double' type for startTime / endTime, not 'unrestricted double':
- https://w3c.github.io/webvtt/#the-vttcue-interface

Otherwise, we end up potentially returning NaN for TextTrackCue.startTime / endTime, even though those correctly use type 'double':
- https://html.spec.whatwg.org/multipage/media.html#texttrackcue
Comment 1 Chris Dumez 2018-02-20 16:13:54 PST 
I have verified that this new behavior would be consistent with Chrome.
Comment 2 Chris Dumez 2018-02-20 16:16:04 PST 
(In reply to Chris Dumez from comment #1)
> I have verified that this new behavior would be consistent with Chrome.

Would also be consistent with Firefox.
Comment 3 Chris Dumez 2018-02-20 16:30:33 PST 
Created attachment 334316 [details]
Patch
Comment 4 Chris Dumez 2018-02-20 16:38:11 PST 
Created attachment 334317 [details]
Patch
Comment 5 WebKit Commit Bot 2018-02-21 11:36:53 PST 
Comment on attachment 334317 [details]
Patch

Clearing flags on attachment: 334317

Committed r228886: <https://trac.webkit.org/changeset/228886>
Comment 6 WebKit Commit Bot 2018-02-21 11:36:54 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-02-21 11:37:28 PST 
<rdar://problem/37754585>