RESOLVED FIXED 182988
VTTCue constructor should use 'double' type for startTime / endTime 
https://bugs.webkit.org/show_bug.cgi?id=182988
Summary VTTCue constructor should use 'double' type for startTime / endTime
Chris Dumez
Reported 2018-02-20 16:12:59 PST
VTTCue constructor should use 'double' type for startTime / endTime, not 'unrestricted double': - https://w3c.github.io/webvtt/#the-vttcue-interface Otherwise, we end up potentially returning NaN for TextTrackCue.startTime / endTime, even though those correctly use type 'double': - https://html.spec.whatwg.org/multipage/media.html#texttrackcue
Attachments
Patch (5.83 KB, patch)
2018-02-20 16:30 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (8.17 KB, patch)
2018-02-20 16:38 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-02-20 16:13:54 PST
I have verified that this new behavior would be consistent with Chrome.
Chris Dumez
Comment 2 2018-02-20 16:16:04 PST
(In reply to Chris Dumez from comment #1) > I have verified that this new behavior would be consistent with Chrome. Would also be consistent with Firefox.
Chris Dumez
Comment 3 2018-02-20 16:30:33 PST
Created attachment 334316 [details] Patch
Chris Dumez
Comment 4 2018-02-20 16:38:11 PST
Created attachment 334317 [details] Patch
WebKit Commit Bot
Comment 5 2018-02-21 11:36:53 PST
Comment on attachment 334317 [details] Patch Clearing flags on attachment: 334317 Committed r228886: <https://trac.webkit.org/changeset/228886>
WebKit Commit Bot
Comment 6 2018-02-21 11:36:54 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-02-21 11:37:28 PST
<rdar://problem/37754585>
Note You need to log in before you can comment on or make changes to this bug.