WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
182963
[css3-text] Skip tests that need ENABLE_CSS3_TEXT
https://bugs.webkit.org/show_bug.cgi?id=182963
Summary
[css3-text] Skip tests that need ENABLE_CSS3_TEXT
Manuel Rego Casasnovas
Reported
2018-02-20 04:32:22 PST
[css3-text] Skip tests that need ENABLE_CSS3_TEXT
Attachments
Patch
(8.59 KB, patch)
2018-02-20 04:32 PST
,
Manuel Rego Casasnovas
no flags
Details
Formatted Diff
Diff
Patch for landing
(8.58 KB, patch)
2018-02-20 05:35 PST
,
Manuel Rego Casasnovas
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1
2018-02-20 04:32:39 PST
Created
attachment 334259
[details]
Patch
Manuel Rego Casasnovas
Comment 2
2018-02-20 04:42:03 PST
Due to #179989 I've been investigating a little bit about ENABLE_CSS3_TEXT. It's used just for a few things: * 2 properties: text-align-last and text-justify. * And a few new keywords for text-indent properties. None of the ports is currently enabling it, neither running the tests. I've enabled the feature and only the test checking parsing pass, but the ones checking the behavior still fail. So this code seems to be rotten, some of these patches came from 2012-2014. In the past GTK+ was running the tests and detected that some things start to break (see
bug #163980
and
bug #163982
). My patch here is only moving the flagged tests to the generic TestExpectations file. As this was repeated now for all ports. I guess it'd be good to have a proper discussion about this flag and the plans around it (if any).
Manuel Rego Casasnovas
Comment 3
2018-02-20 05:35:54 PST
Created
attachment 334263
[details]
Patch for landing
WebKit Commit Bot
Comment 4
2018-02-20 06:11:10 PST
Comment on
attachment 334263
[details]
Patch for landing Clearing flags on attachment: 334263 Committed
r228817
: <
https://trac.webkit.org/changeset/228817
>
WebKit Commit Bot
Comment 5
2018-02-20 06:11:12 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6
2018-02-20 06:12:35 PST
<
rdar://problem/37706158
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug