Bug 182958 - [Cairo] Leverage ShadowBlur without using scratch buffer, target GraphicsContext
Summary: [Cairo] Leverage ShadowBlur without using scratch buffer, target GraphicsContext
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-19 23:44 PST by Zan Dobersek
Modified: 2018-02-20 02:59 PST (History)
3 users (show)

See Also:


Attachments
Patch (29.48 KB, patch)
2018-02-20 00:37 PST, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch for landing (29.49 KB, patch)
2018-02-20 02:43 PST, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2018-02-19 23:44:41 PST
[Cairo] Leverage ShadowBlur without using scratch buffer, target GraphicsContext
Comment 1 Zan Dobersek 2018-02-20 00:37:25 PST
Created attachment 334250 [details]
Patch
Comment 2 Carlos Garcia Campos 2018-02-20 01:06:30 PST
Comment on attachment 334250 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334250&action=review

> Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:181
> +    if (image) {

Use an early return here.

> Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:237
> +        (GraphicsContext& shadowContext)

Move this to previous line for consistency with other lambdas.
Comment 3 Zan Dobersek 2018-02-20 02:43:35 PST
Created attachment 334256 [details]
Patch for landing
Comment 4 Zan Dobersek 2018-02-20 02:52:18 PST
Comment on attachment 334256 [details]
Patch for landing

Clearing flags on attachment: 334256

Committed r228776: <https://trac.webkit.org/changeset/228776>
Comment 5 Zan Dobersek 2018-02-20 02:52:23 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-02-20 02:59:53 PST
<rdar://problem/37702933>